◐ Shell
reader mode source ↗
Skip to content

bpo-39026: Allow relative include paths#20181

Closed
knjmooney wants to merge 1 commit into
python:mainfrom
knjmooney:fix-issue-39026
Closed

bpo-39026: Allow relative include paths#20181
knjmooney wants to merge 1 commit into
python:mainfrom
knjmooney:fix-issue-39026

Conversation

@knjmooney

@knjmooney knjmooney commented May 18, 2020

Copy link
Copy Markdown

Prior to this change, the following would fail to compile with gcc main.c

#include "include/python3.9/Python.h"
int main() {}

The compiler would complain that cpython/initconfig.h didn't exist.

https://bugs.python.org/issue39026

Prior to this change, the following would fail to compile with gcc main.c

    #include "include/python3.9/Python.h"
    int main() {}

The compiler would complain that cpython/initconfig.h didn't exist.
@knjmooney

Copy link
Copy Markdown
Author

This was broken in python 3.8

@rickmark

rickmark commented Nov 2, 2021

Copy link
Copy Markdown

This issue has been open for a while, but the current 3.10 build from the python site still hasn't fixed the framework. Is this PR being held on the idea it is better to not integrate and rename the files and references?

Also on top of this Xcode will complain bitterly about python headers using double quoted rather than angle bracket syntax. This is the other thing breaking embedding python on macOS apps.

It could be solved by pragma, by moving to angle brackets or by including instructions to disable that warning

@vstinner

vstinner commented Nov 9, 2021

Copy link
Copy Markdown
Member

I wrote a different fix: PR #29488. Can someone please check if it fix the issue with Xcode?

@vstinner

Copy link
Copy Markdown
Member

Thanks for working on this issue. I fixed the issue differently: #29488

@vstinner vstinner closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants