◐ Shell
reader mode source ↗
Skip to content

bpo-30524: Write unit tests for FASTCALL#2022

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:test_fastcall
Jun 9, 2017
Merged

bpo-30524: Write unit tests for FASTCALL#2022
vstinner merged 1 commit into
python:masterfrom
vstinner:test_fastcall

Conversation

@vstinner

@vstinner vstinner commented Jun 9, 2017

Copy link
Copy Markdown
Member

Test C functions:

  • _PyObject_FastCall()
  • _PyObject_FastCallDict()
  • _PyObject_FastCallKeywords()

@vstinner vstinner requested a review from serhiy-storchaka June 9, 2017 11:23
@vstinner vstinner added the tests label Jun 9, 2017
@vstinner vstinner mentioned this pull request Jun 9, 2017
Merged
@vstinner
bpo-30524: Write unit tests for FASTCALL …
ba51ca0 
Test C functions:

* _PyObject_FastCall()
* _PyObject_FastCallDict()
* _PyObject_FastCallKeywords()
@vstinner

vstinner commented Jun 9, 2017

Copy link
Copy Markdown
Member Author

I rewrote my change to test much more cases. Most (or all?) possible ways to call FastCall functions should now be tested.

serhiy-storchaka
serhiy-storchaka approved these changes Jun 9, 2017
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Would be nice to backport tests at least to 3.6. This could expose 3.6 bugs fixed in 3.7.

@vstinner vstinner merged commit 3b5cf85 into python:master Jun 9, 2017
@vstinner vstinner deleted the test_fastcall branch June 9, 2017 14:48
@vstinner

vstinner commented Jun 9, 2017

Copy link
Copy Markdown
Member Author

Would be nice to backport tests at least to 3.6.

Sure, I wrote this change for 3.6, to test the datetime.datetime.now() bug :-) But obvious, firstI wrote it for master.

vstinner added a commit that referenced this pull request Jun 9, 2017
@vstinner
bpo-30524: Write unit tests for FASTCALL (#2022) (#2030) …
b757745 
Test C functions:

* _PyObject_FastCall()
* _PyObject_FastCallDict()
* _PyObject_FastCallKeywords()
(cherry picked from commit 3b5cf85)
ma8ma added a commit to ma8ma/cpython that referenced this pull request Jun 13, 2017
@ma8ma
Merge commit 'master' into pep539-tss-api …
e49207b 
Resolve conflicts:
3b5cf85 bpo-30524: Write unit tests for FASTCALL (python#2022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @serhiy-storchaka @the-knights-who-say-ni