bpo-40334: Correctly generate C parser when assigned var is None#20296
bpo-40334: Correctly generate C parser when assigned var is None#20296pablogsal merged 3 commits into
Conversation
Sorry, something went wrong.
When there are 2 negative lookaheads in a same rule, let's say
`!"(" blabla "," !")"`, there will the 2 `FunctionCall`'s where
assigned value is None. Currently when the `add_var` is called
the first one will be ignored (since it will be returned as same
from dedupe because there aren't any `None` named variables in
locals, but when the second lookahead's var is sent to dedupe it
will be returned as `None_1` and this wont be ignored by the
declaration generator in the `visit_Alt`. This patch adds an explicit
check to `add_var` to distinguish whether if there is a variable or not.
|
Could you add a test? |
Sorry, something went wrong.
|
I couldnt find the suitable place to add test, would you give me a hint about it? |
Sorry, something went wrong.
Sorry, something went wrong.
|
or alternatively https://github.com/python/cpython/blob/master/Lib/test/test_peg_generator/test_c_parser.py if you cannot reproduce it in the Python version. |
Sorry, something went wrong.
|
I dont know if this test is suitable, but I couldn't find a better way to test this. |
Sorry, something went wrong.
|
Also, why mypy has not catched this? |
Sorry, something went wrong.
This reverts commit 5440280.
…honGH-20296) When there are 2 negative lookaheads in the same rule, let's say `!"(" blabla "," !")"`, there will the 2 `FunctionCall`'s where assigned value is None. Currently when the `add_var` is called the first one will be ignored but when the second lookahead's var is sent to dedupe it will be returned as `None_1` and this won't be ignored by the declaration generator in the `visit_Alt`. This patch adds an explicit check to `add_var` to distinguish whether if there is a variable or not.
When there are 2 negative lookaheads in a same rule, let's say
!"(" blabla "," !")", there will the 2FunctionCall's whereassigned value is None. Currently when the
add_varis calledthe first one will be ignored (since it will be returned as same
from dedupe because there aren't any
Nonenamed variables inlocals, but when the second lookahead's var is sent to dedupe it
will be returned as
None_1and this wont be ignored by thedeclaration generator in the
visit_Alt. This patch adds an explicitcheck to
add_varto distinguish whether if there is a variable or not.https://bugs.python.org/issue40334