◐ Shell
reader mode source ↗
Skip to content

Revert "bpo-32604: PEP 554 for use in test suite (GH-19985)"#20465

Merged
vstinner merged 1 commit into
python:masterfrom
pablogsal:revert_interpreters
May 27, 2020
Merged

Revert "bpo-32604: PEP 554 for use in test suite (GH-19985)"#20465
vstinner merged 1 commit into
python:masterfrom
pablogsal:revert_interpreters

Conversation

@pablogsal

@pablogsal pablogsal commented May 27, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal requested a review from vstinner May 27, 2020 20:35
@pablogsal pablogsal requested a review from nanjekyejoannah May 27, 2020 20:35
vstinner
vstinner approved these changes May 27, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. I agree with https://bugs.python.org/issue32604#msg370130 to revert.

@nanjekyejoannah

nanjekyejoannah commented May 27, 2020

Copy link
Copy Markdown
Contributor

You can revert until I look probably this weekend

@vstinner vstinner merged commit 7d80b35 into python:master May 27, 2020
@bedevere-bot

bedevere-bot commented May 27, 2020

Copy link
Copy Markdown

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@vstinner

vstinner commented May 27, 2020

Copy link
Copy Markdown
Member

You can revert until I look probably this weekend

Ok, thanks @nanjekyejoannah. I merged the PR.

@pablogsal pablogsal deleted the revert_interpreters branch May 19, 2021 18:57
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @nanjekyejoannah @bedevere-bot @vstinner @the-knights-who-say-ni