◐ Shell
reader mode source ↗
Skip to content

bpo-37878: PyThreadState_DeleteCurrent() was not removed#20489

Merged
vstinner merged 2 commits into
python:masterfrom
vstinner:whatnews39_delete_current
May 28, 2020
Merged

bpo-37878: PyThreadState_DeleteCurrent() was not removed#20489
vstinner merged 2 commits into
python:masterfrom
vstinner:whatnews39_delete_current

Conversation

@vstinner

@vstinner vstinner commented May 28, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Update What's New in Python 3.9.

https://bugs.python.org/issue37878

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels May 28, 2020
@vstinner vstinner mentioned this pull request May 28, 2020
Merged
@vstinner

vstinner commented May 28, 2020

Copy link
Copy Markdown
Member Author

Issue reported at #15315 (comment)

corona10
corona10 approved these changes May 28, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

lgtm

@henryiii

henryiii commented May 28, 2020

Copy link
Copy Markdown
Contributor

Should you mention that it has been moved? There is a section below about changes to the limited ABI that it might fit in. If PyBind11 is the only user, though, we already know that. :)

henryiii
henryiii approved these changes May 28, 2020
View reviewed changes

@henryiii henryiii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks great to me! Thanks!

@henryiii henryiii mentioned this pull request May 28, 2020
Closed
@vstinner

vstinner commented May 28, 2020

Copy link
Copy Markdown
Member Author

Should you mention that it has been moved? There is a section below about changes to the limited ABI that it might fit in.

Done.

If PyBind11 is the only user, though, we already know that. :)

I don't understand why you mention PyBind11 here. In #15315 (comment) you wrote that PyBind11 does not use the limited C API. So PyBind11 is not impactd by https://bugs.python.org/issue37878 changes, right?

You also wrote "Now that 3.9b1 is out, PyBind11-based libraries cannot build" but you didn't explain what is your error.

I don't understand what are you expecting? Do you want to move back the function to the limited C API? Does Pybind11 use the limited C API or not? It's unclear.

@henryiii

henryiii commented May 28, 2020

Copy link
Copy Markdown
Contributor

It needs to make sure it includes the correct header since this has moved, but otherwise, it does not need to change. PyBind11 does not use the limited API.

There is currently a different issue as well, but I think I was only tripping up on a deprecated warning and falling to compile because I had warnings as errors. I'm setting up a PyBind11 CI build on Python 3.9 and so far it looks promising. I don't think there's an issue from the Python side.

Thanks!

@vstinner

vstinner commented May 28, 2020

Copy link
Copy Markdown
Member Author

It needs to make sure it includes the correct header

Include/cpython/pystate.h is included automatically by Include/pystate.h and cannot be included directly (it fails with a compilation error).

@vstinner vstinner merged commit fda7f6d into python:master May 28, 2020
@miss-islington

miss-islington commented May 28, 2020

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@vstinner vstinner deleted the whatnews39_delete_current branch May 28, 2020 16:26
@bedevere-bot

bedevere-bot commented May 28, 2020

Copy link
Copy Markdown

GH-20496 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 28, 2020
@miss-islington @vstinner
bpo-37878: PyThreadState_DeleteCurrent() was not removed (GH-20489) …
6a47864 
Update What's New in Python 3.9.

PyThreadState_DeleteCurrent was not removed, but excluded from the limited C API.
(cherry picked from commit fda7f6d)

Co-authored-by: Victor Stinner <vstinner@python.org>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 30, 2020
@CuriousLearner
Merge branch 'master' of github.com:python/cpython into bpo-26543 …
d3d7100 
* 'master' of github.com:python/cpython: (497 commits)
  bpo-40061: Fix a possible refleak in _asynciomodule.c (pythonGH-19748)
  bpo-40798: Generate a different message for already removed elements (pythonGH-20483)
  closes bpo-29017: Update the bindings for Qt information with PySide2 (pythonGH-20149)
  bpo-39885: Make IDLE context menu cut and copy work again (pythonGH-18951)
  bpo-29882: Add an efficient popcount method for integers (python#771)
  Further de-linting of zoneinfo module (python#20499)
  bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros (pythonGH-20435)
  Indicate that abs() method accept argument that implement __abs__(), just like call() method in the docs (pythonGH-20509)
  bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. (pythongh-17620)
  bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448)
  bpo-30064: Properly skip unstable loop.sock_connect() racing test (pythonGH-20494)
  Note the output ordering of combinatoric functions (pythonGH-19732)
  bpo-40474: Updated coverage.yml to better report coverage stats (python#19851)
  bpo-40806: Clarify that itertools.product immediately consumes its inpt (pythonGH-20492)
  bpo-1294959: Try to clarify the meaning of platlibdir (pythonGH-20332)
  bpo-37878: PyThreadState_DeleteCurrent() was not removed (pythonGH-20489)
  bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time (pythonGH-20493)
  bpo-40755: Add missing multiset operations to Counter() (pythonGH-20339)
  bpo-25920: Remove socket.getaddrinfo() lock on macOS (pythonGH-20177)
  bpo-40275: Fix test.support.threading_helper (pythonGH-20488)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

+1 more reviewer

@henryiii henryiii henryiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner @henryiii @miss-islington @bedevere-bot @corona10 @the-knights-who-say-ni