◐ Shell
reader mode source ↗
Skip to content

[3.7] bpo-40807: Show warnings once from codeop._maybe_compile (GH-20486)#20673

Merged
miss-islington merged 3 commits into
python:3.7from
miss-islington:backport-052d3fc-3.7
Jun 9, 2020
Merged

[3.7] bpo-40807: Show warnings once from codeop._maybe_compile (GH-20486)#20673
miss-islington merged 3 commits into
python:3.7from
miss-islington:backport-052d3fc-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 6, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

  • bpo-40807: Show warnings once from codeop._maybe_compile

  • Move catch_warnings

  • news

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
(cherry picked from commit 052d3fc)

Co-authored-by: Cheryl Sabella cheryl.sabella@gmail.com

https://bugs.python.org/issue40807

@csabella @miss-islington
bpo-40807: Show warnings once from codeop._maybe_compile (pythonGH-20486 …
8130a08 
)

* bpo-40807: Show warnings once from codeop._maybe_compile

* Move catch_warnings

* news

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 052d3fc)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2020
Merged
@miss-islington

miss-islington commented Jun 6, 2020

Copy link
Copy Markdown
Contributor Author

@csabella and @terryjreedy: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington

miss-islington commented Jun 6, 2020

Copy link
Copy Markdown
Contributor Author

@csabella and @terryjreedy: Status check is done, and it's a failure ❌ .

@terryjreedy

terryjreedy commented Jun 6, 2020

Copy link
Copy Markdown
Member

With the test.support change backported, the new test runs on 3.7 and fails on
self.assertEqual(len(w.warnings), 1) because '0 is 0' does not cause SyntaxWarning in 3.7. I believe the same might be true of '\e' and DeprecationWarning. We could make the test pass by changing 1 to 0, but that would be equivalent to deleting the test, and the blurb would still be wrong.

I think we should hold off on this until we learn of code that will make the current test (and blurb) relevant, or until we are sure that there is no such code, or until the next and final 3.7 bugfix release (in about a month).

terryjreedy
terryjreedy requested changes Jun 6, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

See previous comment. Either change test with relevant code, so it passes, or close upon deciding there is no such code or 3.7 goes into security mode.

@python python deleted a comment from bedevere-bot Jun 6, 2020
@csabella csabella requested a review from terryjreedy June 9, 2020 10:43
@miss-islington miss-islington merged commit 4b378ac into python:3.7 Jun 9, 2020
@miss-islington miss-islington deleted the backport-052d3fc-3.7 branch June 9, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

@csabella csabella csabella left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @terryjreedy @csabella @the-knights-who-say-ni @bedevere-bot