bpo-1635741: Port _dbm module to multiphase initialization#20848
Conversation
|
I' ve checked the memory leak with these scripts and no leaks found def test_dbm(self):
code = textwrap.dedent(r"""
import glob
import test.support
dbm = test.support.import_module('_dbm')
_fname = test.support.TESTFN
def delete_files():
for f in glob.glob(_fname + "*"):
test.support.unlink(f)
f = dbm.open(_fname, 'n')
f[b'g'] = b"indented"
f.close()
delete_files()
""")
ret = test.support.run_in_subinterp(code)
self.assertEqual(ret, 0) |
Sorry, something went wrong.
corona10
left a comment
There was a problem hiding this comment.
@shihai1991 Thanks shihai! I've updated it
Sorry, something went wrong.
shihai1991
left a comment
There was a problem hiding this comment.
Thanks, LGTM.
Sorry, something went wrong.
|
When you're done making the requested changes, leave the comment: |
Sorry, something went wrong.
corona10
left a comment
There was a problem hiding this comment.
I have made the requested changes; please review again
Sorry, something went wrong.
Co-authored-by: Victor Stinner <vstinner@python.org>
26030f1 to
b325856
Compare
June 15, 2020 15:21
vstinner
left a comment
There was a problem hiding this comment.
Thanks! It's now much better!
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Sorry, something went wrong.
https://bugs.python.org/issue1635741