◐ Shell
reader mode source ↗
Skip to content

[3.6] bpo-29532: Altering a kwarg dictionary passed to functools.partial() …#209

Merged
serhiy-storchaka merged 1 commit into
python:3.6from
serhiy-storchaka:bpo29532-py36
Feb 21, 2017
Merged

[3.6] bpo-29532: Altering a kwarg dictionary passed to functools.partial() …#209
serhiy-storchaka merged 1 commit into
python:3.6from
serhiy-storchaka:bpo29532-py36

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Feb 21, 2017

Copy link
Copy Markdown
Member

…no longer affects a partial object after creation.

@serhiy-storchaka
bpo-29532: Altering a kwarg dictionary passed to functools.partial() … …
ff1cd32 
…no longer affects a partial object after creation.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error cherry-pick for 3.6 labels Feb 21, 2017
@codecov

codecov Bot commented Feb 21, 2017

Copy link
Copy Markdown

Codecov Report

Merging #209 into 3.6 will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              3.6     #209      +/-   ##
==========================================
+ Coverage   82.39%   82.39%   +<.01%     
==========================================
  Files        1430     1430              
  Lines      351246   351252       +6     
==========================================
+ Hits       289392   289413      +21     
+ Misses      61854    61839      -15
Impacted Files Coverage Δ
Lib/test/test_functools.py 94.55% <100%> (+0.02%) ✅
Lib/_strptime.py 94.68% <ø> (-0.34%) ❌
Lib/test/lock_tests.py 86.81% <ø> (-0.29%) ❌
Lib/test/test_strptime.py 94.75% <ø> (-0.27%) ❌
Lib/test/test_io.py 96.91% <ø> (ø) ✅
Lib/test/test_logging.py 95.1% <ø> (+0.04%) ✅
Lib/threading.py 82.08% <ø> (+0.17%) ✅
Lib/test/test_random.py 98.65% <ø> (+0.19%) ✅
Lib/test/test_smtplib.py 86.71% <ø> (+0.22%) ✅
Lib/test/test_ftplib.py 95.98% <ø> (+0.25%) ✅
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b3cdd...ff1cd32. Read the comment docs.

@serhiy-storchaka serhiy-storchaka changed the title bpo-29532: Altering a kwarg dictionary passed to functools.partial() … Feb 21, 2017
@serhiy-storchaka serhiy-storchaka merged commit e48fd93 into python:3.6 Feb 21, 2017
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 21, 2017
@serhiy-storchaka
bpo-29532: Altering a kwarg dictionary passed to functools.partial() … …
8a5d5c8 
…no longer affects a partial object after creation. (python#209)
@serhiy-storchaka serhiy-storchaka deleted the bpo29532-py36 branch February 21, 2017 20:37
@serhiy-storchaka

serhiy-storchaka commented Feb 27, 2017

Copy link
Copy Markdown
Member Author

Sorry. Could you please fix this Berker? I'm not experienced with git.

@berkerpeksag

berkerpeksag commented Feb 27, 2017

Copy link
Copy Markdown
Member

Done: #338

@Mariatta Mariatta mentioned this pull request Mar 7, 2017
Merged
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update pytest from 4.2.1 to 4.3.0 (#209)
05c5e8d
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@jaraco
Merge pull request python#209 from python/feature/skeleton …
f953676 
Adopt best practices from jaraco/skeleton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag left review comments

@methane methane methane approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @berkerpeksag @methane @the-knights-who-say-ni