◐ Shell
reader mode source ↗
Skip to content

bpo-41056: Fix a possible MemoryError leak within zoneinfo.#21007

Merged
miss-islington merged 4 commits into
python:masterfrom
gpshead:coverity_zoneinfo
Jun 22, 2020
Merged

bpo-41056: Fix a possible MemoryError leak within zoneinfo.#21007
miss-islington merged 4 commits into
python:masterfrom
gpshead:coverity_zoneinfo

Conversation

@gpshead

@gpshead gpshead commented Jun 20, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

This was detected by our Coverity scan as a REVERSE_INULL issue.

https://bugs.python.org/issue41056

Automerge-Triggered-By: @gpshead

@gpshead
Fix a possible MemoryError leak within zoneinfo. …
f7e5c17 
This was detected by coverity as a REVERSE_INULL issue.
@gpshead gpshead added needs backport to 3.8 type-bug An unexpected behavior, bug, or error and removed needs backport to 3.8 labels Jun 20, 2020
@gpshead gpshead requested a review from pganssle June 20, 2020 18:33
@pganssle

pganssle commented Jun 20, 2020

Copy link
Copy Markdown
Member

I don't have time to look at this in any detail until tomorrow, but I think @tiran made essentially the same patch in #21003. That one got here first, but this one has a news entry.

Looks simple enough, though, if y'all want to decide which patch to move forward with, the fact that you both came up with the exact same solution is probably a good enough "review". 😛

@gpshead gpshead requested a review from tiran June 21, 2020 19:12
@tiran tiran mentioned this pull request Jun 22, 2020
Closed
@miss-islington miss-islington merged commit d780fa7 into python:master Jun 22, 2020
@miss-islington

miss-islington commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 22, 2020

Copy link
Copy Markdown
Contributor

Sorry @gpshead, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d780fa7931d8ce94994827232d7cca79b0be3bf1 3.9

@miss-islington miss-islington self-assigned this Jun 22, 2020
pganssle pushed a commit to pganssle/cpython that referenced this pull request Jun 23, 2020
@gpshead @pganssle
[3.9] bpo-41056: Fix a possible MemoryError leak within zoneinfo. (py… …
f6b7dfa 
…thonGH-21007)

This was detected by our Coverity scan as a REVERSE_INULL issue.

Automerge-Triggered-By: @gpshead
(cherry picked from commit d780fa7)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot

bedevere-bot commented Jun 23, 2020

Copy link
Copy Markdown

GH-21083 is a backport of this pull request to the 3.9 branch.

pganssle added a commit that referenced this pull request Jun 24, 2020
@pganssle @gpshead
[3.9] bpo-41056: Fix a possible MemoryError leak within zoneinfo. (GH… …
6c56356 
…-21007)

This was detected by our Coverity scan as a REVERSE_INULL issue.

Automerge-Triggered-By: @gpshead
(cherry picked from commit d780fa7)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@gpshead @fasihahmad
bpo-41056: Fix a possible MemoryError leak within zoneinfo. (pythonGH… …
601edd4 
…-21007)

This was detected by our Coverity scan as a REVERSE_INULL issue.

Automerge-Triggered-By: @gpshead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

@pganssle pganssle Awaiting requested review from pganssle

Assignees

@miss-islington miss-islington

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gpshead @pganssle @miss-islington @bedevere-bot @tiran @the-knights-who-say-ni