bpo-31938: Fix default-value signatures of several functions in the select module#21066
Conversation
|
If this is the proper way to do it, this PR should also fix the default values for |
Sorry, something went wrong.
|
Oops, I didn't notice that you proposed a PR and so I wrote PR #21067 which is the same fix :-) Copy of my comment there. inspect.signature() doesn't see the event_mask. Is it a bug in signature which doesn't support a signature written on two lines? cc @serhiy-storchaka @1st1 @ambv So pydoc doesn't show the whole signature: |
Sorry, something went wrong.
IMO the fix is correct, so I concur thta the two other functions signature should also be fixed. By the way, I suggest to rephase the NEWS entry to explain that the change fix the "signature" rather than fixing "pydoc". |
Sorry, something went wrong.
8f69adc to
ea850df
Compare
June 23, 2020 20:20
|
I fixed a few others as well -- good catch |
Sorry, something went wrong.
|
Sorry, @asottile and @vstinner, I could not cleanly backport this to |
Sorry, something went wrong.
|
Sorry @asottile and @vstinner, I had trouble checking out the |
Sorry, something went wrong.
|
@asottile: Automated backport failed. Can you try to backport it manually (use cherry_picker or git cherry-pick -x)? |
Sorry, something went wrong.
…elect module (pythonGH-21066) (cherry picked from commit d051801)
…elect module (pythonGH-21066) (cherry picked from commit d051801)
|
pydoc doesn't show the eventmask parameter whereas it is in select.epoll.register.text_signature. I created bpo-41095: "inspect.signature() doesn't parse text_signature containing a newline character". |
Sorry, something went wrong.
this appears to have regressed in 6dc57e2
https://bugs.python.org/issue31938