bpo-1635741: Port sha256 module to multiphase init (PEP 489)#21189
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
bc4d566 to
d63818d
Compare
June 27, 2020 22:45
d63818d to
9f9e45a
Compare
June 28, 2020 21:23
|
edtited the commit msg and repushed so that it would pick up the CLA which I signed yesterday. Not sure what the Misc/NEWS.d/next is about |
Sorry, something went wrong.
If you add a feature which could effect the user, you should describe what you have changed in Misc/NEWS.d/next. A reference PR of Dong-hee Na: |
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
|
@corona10 any change still requested? @shihai1991 @vstinner I started looking at doing heap types. First a disclaimer I'm new in this code so maybe I'm missing some context. I am seeing auto-generated files from clinic that don't take a module pointer as an input, so the module->state approach used by _gdbmmodule would only work if I could modify all of those auto-generated files (and presumably the system which generates them). |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
@corona10, @shihai1991: Would you mind to review the change?
@corona10: Feel free to merge if the change looks good to you ;-)
Sorry, something went wrong.
corona10
left a comment
There was a problem hiding this comment.
LGTM Thanks for the work!
Sorry, something went wrong.
|
oh, sorry, I am late, LGTM. |
Sorry, something went wrong.
Link to issue
https://bugs.python.org/issue1635741