{{ message }}
bpo-41100: ctypes: use the correct ABI for variadic functions#21242
Closed
lawrence-danna-apple wants to merge 1 commit into
Closed
bpo-41100: ctypes: use the correct ABI for variadic functions#21242lawrence-danna-apple wants to merge 1 commit into
lawrence-danna-apple wants to merge 1 commit into
Conversation
On arm64 the calling convention for variardic functions is different than the convention for fixed-arg functions of the same arg types. ctypes needs to use ffi_prep_cif_var to tell libffi which calling convention to use. This patch adds a new attribute "f.variadic" for ctypes function pointers, so users can specify which functions are variadic. It will also auto-detect varargs when a function is called with more arguments than f.argtypes specifies. Since this is a new option and it only matters on arm64 on apple platforms, lots of existing code will not set f.variadic. This will do the right thing in most situations.
bf3fbbf to
fc54fcb
Compare
July 1, 2020 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
On arm64 the calling convention for variardic functions is different
than the convention for fixed-arg functions of the same arg types.
ctypes needs to use ffi_prep_cif_var to tell libffi which calling
convention to use.
https://bugs.python.org/issue41100