◐ Shell
reader mode source ↗
Skip to content

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints#21553

Merged
gvanrossum merged 2 commits into
python:masterfrom
wyfo:forwardref_recursive_evaluation
Jul 22, 2020
Merged

bpo-41341: Recursive evaluation of ForwardRef in get_type_hints#21553
gvanrossum merged 2 commits into
python:masterfrom
wyfo:forwardref_recursive_evaluation

Conversation

@wyfo

@wyfo wyfo commented Jul 20, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The issue raised by recursive evaluation is infinite recursion with
recursive types. In that case, only the first recursive ForwardRef is
evaluated.

https://bugs.python.org/issue41341

@wyfo
bpo-41341: Recursive evaluation of ForwardRef in get_type_hints …
2389c25 
The issue raised by recursive evaluation is infinite recursion with
recursive types. In that case, only the first recursive ForwardRef is
evaluated.
@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
gvanrossum
gvanrossum reviewed Jul 21, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

@isidentical This might help moving https://bugs.python.org/issue38605 forward (make from __future__ import annotations the default).

@ambv Assuming we get this to work, what would you think of backporting it to 3.9, even though beta5 is already released? On the one hand it's awfully late for such a change (and experience with the bpo issue above suggests it's not painful). On the other hand getting the same behavior for forward refs in 3.9 with from __future__ import annotations as it will have in 3.10 (regardless of that import) seems useful.

@isidentical

isidentical commented Jul 22, 2020

Copy link
Copy Markdown
Member

@isidentical This might help moving https://bugs.python.org/issue38605 forward (make from future import annotations the default).

I had my own implementations, but I think I am going to rebase because it was kind of a workaround.

@gvanrossum gvanrossum merged commit 653f420 into python:master Jul 22, 2020
@bedevere-bot

bedevere-bot commented Jul 22, 2020

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@gvanrossum

gvanrossum commented Jul 22, 2020

Copy link
Copy Markdown
Member

@ambv @pablogsal can I please have a decision on whether to backport this to 3.9? See my previous comment.

@pablogsal

pablogsal commented Jul 22, 2020

Copy link
Copy Markdown
Member

@ambv @pablogsal can I please have a decision on whether to backport this to 3.9? See my previous comment.

I think it makes sense, but being this 3.9 this is @ambv's decision

@miss-islington

miss-islington commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

Thanks @wyfo for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2020
@wyfo @miss-islington
bpo-41341: Recursive evaluation of ForwardRef in get_type_hints (pyth… …
50ebde5 
…onGH-21553)

The issue raised by recursive evaluation is infinite recursion with
recursive types. In that case, only the first recursive ForwardRef is
evaluated.
(cherry picked from commit 653f420)

Co-authored-by: wyfo <joperez@hotmail.fr>
@bedevere-bot

bedevere-bot commented Jul 26, 2020

Copy link
Copy Markdown

GH-21629 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jul 26, 2020
@miss-islington @wyfo
bpo-41341: Recursive evaluation of ForwardRef in get_type_hints (GH-2… …
41d1c04 
…1553)

The issue raised by recursive evaluation is infinite recursion with
recursive types. In that case, only the first recursive ForwardRef is
evaluated.
(cherry picked from commit 653f420)

Co-authored-by: wyfo <joperez@hotmail.fr>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@wyfo @shihai1991
bpo-41341: Recursive evaluation of ForwardRef in get_type_hints (pyth… …
0af740d 
…on#21553)

The issue raised by recursive evaluation is infinite recursion with
recursive types. In that case, only the first recursive ForwardRef is
evaluated.
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@wyfo @xzy3-cdc
bpo-41341: Recursive evaluation of ForwardRef in get_type_hints (pyth… …
0dc2d89 
…on#21553)

The issue raised by recursive evaluation is infinite recursion with
recursive types. In that case, only the first recursive ForwardRef is
evaluated.
johnandersen777 pushed a commit to johnandersen777/dffml that referenced this pull request Jun 2, 2022
@pdxjohnny
util: python: is_forward_ref_dataclass: Helper to check for ForwardRe… …
781f0c4 
…f or str

Related: python/cpython#21553 (comment)
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
johnandersen777 pushed a commit to johnandersen777/dffml that referenced this pull request Jun 23, 2022
@pdxjohnny
util: python: is_forward_ref_dataclass: Helper to check for ForwardRe… …
dbb7c17 
…f or str

Related: python/cpython#21553 (comment)
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
johnandersen777 pushed a commit to johnandersen777/dffml that referenced this pull request Jun 23, 2022
@pdxjohnny
util: python: is_forward_ref_dataclass: Helper to check for ForwardRe… …
1d2821f 
…f or str

Related: python/cpython#21553 (comment)
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
johnandersen777 pushed a commit to intel/dffml that referenced this pull request Jul 7, 2022
@pdxjohnny
util: python: is_forward_ref_dataclass: Helper to check for ForwardRe… …
fc2b052 
…f or str

Related: python/cpython#21553 (comment)
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
johnandersen777 pushed a commit to intel/dffml that referenced this pull request Jul 7, 2022
@pdxjohnny
util: python: is_forward_ref_dataclass: Helper to check for ForwardRe… …
ca4fb6b 
…f or str

Related: python/cpython#21553 (comment)
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
@aronbierbaum aronbierbaum mentioned this pull request Aug 23, 2022
Merged
hauntsaninja pushed a commit to python/typeshed that referenced this pull request Aug 24, 2022
@aronbierbaum
Update ForwardRef._evaluate for Python 3.11 (#8600) …
ef6baca 
recursive_guard argument was added in python/cpython#21553
johnandersen777 pushed a commit to johnandersen777/dffml that referenced this pull request Jan 5, 2023
@pdxjohnny
util: python: is_forward_ref_dataclass: Helper to check for ForwardRe… …
8fcff78 
…f or str

Related: python/cpython#21553 (comment)
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wyfo @the-knights-who-say-ni @isidentical @bedevere-bot @gvanrossum @pablogsal @miss-islington @ambv