◐ Shell
reader mode source ↗
Skip to content

bpo-41100: add runtime checks for MACOSX_DEPLOYMENT_TARGET=10.10#21576

Closed
lawrence-danna-apple wants to merge 2 commits into
python:masterfrom
lawrence-danna-apple:postback-runtime-checks
Closed

bpo-41100: add runtime checks for MACOSX_DEPLOYMENT_TARGET=10.10#21576
lawrence-danna-apple wants to merge 2 commits into
python:masterfrom
lawrence-danna-apple:postback-runtime-checks

Conversation

@lawrence-danna-apple

@lawrence-danna-apple lawrence-danna-apple commented Jul 21, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

In order to support a universal2 build, supporting Mac OS 11 on arm64 and Mac OS on
x86_64 going back to 10.10, we need to add in runtime checks for functions that will
be detected as present by autoconf, because they are in the SDK, but which did not
exist in Mac OS 10.10. This fixes all the instances of -WWunguarded-availability-new
when building with MACOSX_DEPLOYMENT_TARGET=10.10

https://bugs.python.org/issue41100

@lawrence-danna-apple
add runtime checks for MACOSX_DEPLOYMENT_TARGET=10.10 …
fceec42 
In order to support a universal2 build, supporitng Mac OS 11 on arm64 and Mac OS on
x86_64 going back to 10.10, we need to add in runtime checks for functions that will
be detected as present by autoconf, because they are in the SDK, but which did not
exist  in Mac OS 10.10.    This fixes all the instances of -WWunguarded-availability-new
when building with MACOSX_DEPLOYMENT_TARGET=10.10
@lawrence-danna-apple lawrence-danna-apple mentioned this pull request Jul 21, 2020
Closed
@lawrence-danna-apple

lawrence-danna-apple commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

oops, this isn't quite right yet.

@gh-doot

gh-doot commented Jul 21, 2020

Copy link
Copy Markdown

im just new to github.. what does that mean?

@lawrence-danna-apple lawrence-danna-apple deleted the postback-runtime-checks branch July 21, 2020 05:57
@lawrence-danna-apple

lawrence-danna-apple commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

OK it's fixed now

@lawrence-danna-apple

lawrence-danna-apple commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

superseded by #21577

@sumanthratna sumanthratna mentioned this pull request Sep 24, 2020
Closed
@ronaldoussoren ronaldoussoren mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abalkin abalkin Awaiting requested review from abalkin

@pganssle pganssle Awaiting requested review from pganssle

@tiran tiran Awaiting requested review from tiran

2 more reviewers

@maxbelanger maxbelanger maxbelanger left review comments

@sumanthratna sumanthratna sumanthratna left review comments

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lawrence-danna-apple @gh-doot @maxbelanger @sumanthratna @the-knights-who-say-ni @bedevere-bot