bpo-41100: add runtime checks for MACOSX_DEPLOYMENT_TARGET=10.10#21577
bpo-41100: add runtime checks for MACOSX_DEPLOYMENT_TARGET=10.10#21577lawrence-danna-apple wants to merge 7 commits into
Conversation
Sorry, something went wrong.
In order to support a universal2 build, supporitng Mac OS 11 on arm64 and Mac OS on x86_64 going back to 10.10, we need to add in runtime checks for functions that will be detected as present by autoconf, because they are in the SDK, but which did not exist in Mac OS 10.10. This fixes all the instances of -WWunguarded-availability-new when building with MACOSX_DEPLOYMENT_TARGET=10.10
lawrence-danna-apple
requested review from
abalkin,
pganssle and
tiran
as code owners
July 21, 2020 06:01
|
Thanks for the PR. @ronaldoussoren is working on a similar one at the moment. He can review and resolve differences. |
Sorry, something went wrong.
|
I have a similar patch in #21583, but that one is targeting macOS 10.9 instead of 10.10 and is incomplete and as of yet untested ("it compiles therefore it is correct"). I like your approach with HAVE_..._RUNTIME macro's, that reduces the amount of cruft compared with my approach. |
Sorry, something went wrong.
ronaldoussoren
left a comment
ronaldoussoren
left a comment
There was a problem hiding this comment.
Just some comments at this time. The basic approach looks sane, but I haven't look at the changes in detail yet.
Sorry, something went wrong.
|
Thanks for the PR. The changes in the PR have been used as the basis for changes in GH-22855. |
Sorry, something went wrong.
Reviewers
+1 more reviewer
6 participants
In order to support a universal2 build, supporitng Mac OS 11 on arm64 and Mac OS on
x86_64 going back to 10.10, we need to add in runtime checks for functions that will
be detected as present by autoconf, because they are in the SDK, but which did not
exist in Mac OS 10.10. This fixes all the instances of -WWunguarded-availability-new
when building with MACOSX_DEPLOYMENT_TARGET=10.10
https://bugs.python.org/issue41100