◐ Shell
reader mode source ↗
Skip to content

bpo-31904: disable os.popen and impacted test cases on VxWorks#21687

Merged
vstinner merged 9 commits into
python:masterfrom
Wind-River:fix-issue-31904-shell
Dec 15, 2020
Merged

bpo-31904: disable os.popen and impacted test cases on VxWorks#21687
vstinner merged 9 commits into
python:masterfrom
Wind-River:fix-issue-31904-shell

Conversation

@pxinwr

@pxinwr pxinwr commented Jul 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

VxWorks has no user space shell provided so it can't support os.popen(). Disable it on VxWorks and impacted test cases.

https://bugs.python.org/issue41442

@pxinwr pxinwr force-pushed the fix-issue-31904-shell branch from bcc5ef8 to e37c536 Compare November 24, 2020 08:11
@pxinwr pxinwr changed the title bpo-41442: add unix_shell requirement checking for test_posix.PosixTester.test_getgroups Nov 24, 2020
vstinner
vstinner reviewed Dec 8, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Is this change a temporary workaround until subprocess is fixed on VxWorks, or is this skip supposed to be a temporary workaround?

If it's a temporary workaround, I am not sure if it's a good idea to document the skip.

@pxinwr

pxinwr commented Dec 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Is this change a temporary workaround until subprocess is fixed on VxWorks, or is this skip supposed to be a temporary workaround?

If it's a temporary workaround, I am not sure if it's a good idea to document the skip.

os.popen() runs cmd in shell, i.e. shell=True was set when calling subprocess.Popen(). VxWorks has no user space shell provided so that we can't create a new shell and run commands inside. For the subprocess module, VxWorks can't support features needing shell to run. So when I created this PR, I don't intend to be a temporary workaround.

pxinwr and others added 2 commits December 15, 2020 11:46
@vstinner vstinner merged commit e1e3c2d into python:master Dec 15, 2020
@vstinner

vstinner commented Dec 15, 2020

Copy link
Copy Markdown
Member

Merged, thanks.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pxinwr @adorilson
bpo-31904: Disable os.popen and popen test cases on VxWorks (pythonGH… …
57a349e 
…-21687)
@pxinwr pxinwr deleted the fix-issue-31904-shell branch May 7, 2021 07:42
@kuhlenough kuhlenough mannequin mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

+1 more reviewer

@ZackerySpytz ZackerySpytz

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pxinwr @vstinner @ZackerySpytz @the-knights-who-say-ni @bedevere-bot