{{ message }}
bpo-41463: Generate information about jumps from 'opcode.py' rather than duplicating it in 'compile.c'#21714
Merged
markshannon merged 3 commits intoAug 4, 2020
Merged
Conversation
Member
Sorry, something went wrong.
…te it in 'compile.c'
pablogsal
reviewed
Aug 4, 2020
pablogsal
reviewed
Aug 4, 2020
pablogsal
reviewed
Aug 4, 2020
pablogsal
reviewed
Aug 4, 2020
pablogsal
left a comment
pablogsal
left a comment
Member
There was a problem hiding this comment.
Look great, I left some minor comments
Sorry, something went wrong.
pablogsal
reviewed
Aug 4, 2020
pablogsal
reviewed
Aug 4, 2020
pablogsal
approved these changes
Aug 4, 2020
pablogsal
left a comment
pablogsal
left a comment
Member
There was a problem hiding this comment.
LGTM
I left a comment, feel free to address it before landing
Sorry, something went wrong.
pablogsal
approved these changes
Aug 4, 2020
pablogsal
left a comment
pablogsal
left a comment
Member
There was a problem hiding this comment.
Perfect!
Sorry, something went wrong.
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
…han duplicating it in 'compile.c' (pythonGH-21714) Generate information about jumps from 'opcode.py' rather than duplicate it in 'compile.c'
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…han duplicating it in 'compile.c' (pythonGH-21714) Generate information about jumps from 'opcode.py' rather than duplicate it in 'compile.c'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The motivation for this PR is to avoid errors when modifying compile.c.
Setting the
i_jabsandi_jrelfields of every instruction is error prone and unnecessary.https://bugs.python.org/issue41463