◐ Shell
reader mode source ↗
Skip to content

bpo-29598 Add couple of unit tests for pdb module#218

Closed
archy-rock3t-cloud wants to merge 1 commit into
python:masterfrom
archy-rock3t-cloud:bpo-29598-add-unit-tests-for-pdb
Closed

bpo-29598 Add couple of unit tests for pdb module#218
archy-rock3t-cloud wants to merge 1 commit into
python:masterfrom
archy-rock3t-cloud:bpo-29598-add-unit-tests-for-pdb

Conversation

@archy-rock3t-cloud

Copy link
Copy Markdown

Add unit tests for find_function, getsourcelines and lasti2lineno functions.

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement
  4. If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@archy-rock3t-cloud

Copy link
Copy Markdown
Author

All steps listed above completed

@archy-rock3t-cloud archy-rock3t-cloud force-pushed the bpo-29598-add-unit-tests-for-pdb branch from 2a5a46d to 3479961 Compare February 22, 2017 08:58
@archy-rock3t-cloud

Copy link
Copy Markdown
Author

@Haypo @serhiy-storchaka @methane please review this PR

@methane

methane commented Feb 22, 2017

Copy link
Copy Markdown
Member

Before review, why did you added test for private utility functions?
They are not covered other tests for higher level functions? Do you want cover
edge case of them which cannot test from higher level functions?

@archy-rock3t-cloud

Copy link
Copy Markdown
Author

@methane, because of edge cases. Also it seems easier to write such whitebox tests for small isolated units(and this is what documentation suggests if I understood correctly). Generally I want to write tests for the whole module and because there will be quite a few tests I decided to split it into multiple small PRs.

@methane

methane commented Feb 22, 2017

Copy link
Copy Markdown
Member

OK. I leave some comments.

But I think I'm not suited to this change, because this code uses some inspect magic and
I'm not familiar with inspect and pdb module.
I don't know is there any better way other than than proposed magic.

@archy-rock3t-cloud

Copy link
Copy Markdown
Author

@methane thank you very much for comments, can you please suggest person who can review test for pdb?

@methane

methane commented Feb 22, 2017

Copy link
Copy Markdown
Member

I usually use Experts Index and git history to find experts.

Experts Index doesn't tell expert of pdb. But @1st1 is listed as expert of inspect module.
As reading history of pdb, @birkenfeld did very important jobs for pdb.

@methane

methane commented Feb 22, 2017

Copy link
Copy Markdown
Member

And there are some comments in b.p.o

@archy-rock3t-cloud archy-rock3t-cloud force-pushed the bpo-29598-add-unit-tests-for-pdb branch from 3479961 to fcf80b0 Compare February 22, 2017 13:49
@berkerpeksag berkerpeksag requested a review from xdegaye February 23, 2017 07:48
@methane

methane commented Feb 28, 2017

Copy link
Copy Markdown
Member

While pdb and inspect relying on implementation, PyPy is compatible at this point.
So I don't think cpython_only is required for this, until Python 3.6 implementation
which has incompatible code object born.

akruis added a commit to akruis/cpython that referenced this pull request Aug 4, 2019
…dded SLP

- Fix test_outside to reset cstack_base and cstack_root. Now the
simulation of a call from outside is complete.
- Add test_slp_embed to test embedding Stackless
akruis added a commit to akruis/cpython that referenced this pull request Aug 4, 2019
…terpreter

The fix for Stackless issue 186 (support for sub-interpreters) broke
some typical use cases.
akruis added a commit to akruis/cpython that referenced this pull request May 27, 2021
…dded SLP

- Fix test_outside to reset cstack_base and cstack_root. Now the
simulation of a call from outside is complete.
- Add test_slp_embed to test embedding Stackless. Currently it gets
skipped, because it requires a not yet available class.
akruis added a commit to akruis/cpython that referenced this pull request May 27, 2021
…terpreter

The fix for Stackless issue 186 (support for sub-interpreters) broke
some typical use cases.

(cherry picked from commit 5b29b24)
@micgeronimo micgeronimo mannequin mentioned this pull request Apr 10, 2022
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants