bpo-29598 Add couple of unit tests for pdb module#218
bpo-29598 Add couple of unit tests for pdb module#218archy-rock3t-cloud wants to merge 1 commit into
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
Sorry, something went wrong.
|
All steps listed above completed |
Sorry, something went wrong.
2a5a46d to
3479961
Compare
February 22, 2017 08:58
|
Before review, why did you added test for private utility functions? |
Sorry, something went wrong.
|
@methane, because of edge cases. Also it seems easier to write such whitebox tests for small isolated units(and this is what documentation suggests if I understood correctly). Generally I want to write tests for the whole module and because there will be quite a few tests I decided to split it into multiple small PRs. |
Sorry, something went wrong.
|
OK. I leave some comments. But I think I'm not suited to this change, because this code uses some inspect magic and |
Sorry, something went wrong.
|
@methane thank you very much for comments, can you please suggest person who can review test for pdb? |
Sorry, something went wrong.
|
I usually use Experts Index and git history to find experts. Experts Index doesn't tell expert of pdb. But @1st1 is listed as expert of inspect module. |
Sorry, something went wrong.
|
And there are some comments in b.p.o |
Sorry, something went wrong.
3479961 to
fcf80b0
Compare
February 22, 2017 13:49
|
While pdb and inspect relying on implementation, PyPy is compatible at this point. |
Sorry, something went wrong.
…dded SLP - Fix test_outside to reset cstack_base and cstack_root. Now the simulation of a call from outside is complete. - Add test_slp_embed to test embedding Stackless
…terpreter The fix for Stackless issue 186 (support for sub-interpreters) broke some typical use cases.
…dded SLP - Fix test_outside to reset cstack_base and cstack_root. Now the simulation of a call from outside is complete. - Add test_slp_embed to test embedding Stackless. Currently it gets skipped, because it requires a not yet available class.
…terpreter The fix for Stackless issue 186 (support for sub-interpreters) broke some typical use cases. (cherry picked from commit 5b29b24)
Add unit tests for
find_function,getsourcelinesandlasti2linenofunctions.