◐ Shell
reader mode source ↗
Skip to content

bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0#21895

Merged
1st1 merged 1 commit into
python:masterfrom
elprans:asyncio-fix-wait-for-cancellation-timeout-0
Aug 26, 2020
Merged

bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0#21895
1st1 merged 1 commit into
python:masterfrom
elprans:asyncio-fix-wait-for-cancellation-timeout-0

Conversation

@elprans

@elprans elprans commented Aug 15, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

When I was fixing bpo-32751 back in GH-7216 I missed the case when
timeout is zero or negative. This takes care of that.

Props to @aaliddell for noticing the inconsistency.

https://bugs.python.org/issue32751

@elprans
bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0 …
debcf3e 
When I was fixing bpo-32751 back in pythonGH-7216 I missed the case when
*timeout* is zero or negative.  This takes care of that.

Props to @aaliddell for noticing the inconsistency.
@elprans elprans requested review from 1st1 and asvetlov as code owners August 15, 2020 22:54
@1st1 1st1 closed this Aug 18, 2020
@1st1 1st1 reopened this Aug 18, 2020
@1st1

1st1 commented Aug 18, 2020

Copy link
Copy Markdown
Member

closing/reopening to hopefully fix travis

@1st1 1st1 merged commit c517fc7 into python:master Aug 26, 2020
@miss-islington

miss-islington commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

Thanks @elprans for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Aug 26, 2020

Copy link
Copy Markdown

@1st1: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2020
@elprans @miss-islington
bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <=… …
28b017a 
… 0 (pythonGH-21895)

When I was fixing bpo-32751 back in pythonGH-7216 I missed the case when
*timeout* is zero or negative.  This takes care of that.

Props to @aaliddell for noticing the inconsistency.
(cherry picked from commit c517fc7)

Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
@bedevere-bot

bedevere-bot commented Aug 26, 2020

Copy link
Copy Markdown

GH-21963 is a backport of this pull request to the 3.9 branch.

@miss-islington

miss-islington commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

Sorry, @elprans and @1st1, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c517fc712105c8e5930cb42baaebdbe37fc3e15f 3.8

@miss-islington

miss-islington commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

Sorry @elprans and @1st1, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c517fc712105c8e5930cb42baaebdbe37fc3e15f 3.7

ambv pushed a commit that referenced this pull request Aug 26, 2020
@miss-islington @elprans
bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <=… …
1036ccb 
… 0 (GH-21895) (GH-21963)

When I was fixing bpo-32751 back in GH-7216 I missed the case when
*timeout* is zero or negative.  This takes care of that.

Props to @aaliddell for noticing the inconsistency.
(cherry picked from commit c517fc7)

Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
@bedevere-bot

bedevere-bot commented Aug 26, 2020

Copy link
Copy Markdown

GH-21967 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

bedevere-bot commented Aug 26, 2020

Copy link
Copy Markdown

GH-21968 is a backport of this pull request to the 3.7 branch.

elprans added a commit to elprans/cpython that referenced this pull request Aug 26, 2020
@elprans
[3.7] bpo-32751: Wait for task cancel in asyncio.wait_for() when time… …
e248174 
…out <= 0 (pythonGH-21895)

When I was fixing bpo-32751 back in pythonGH-7216 I missed the case when
*timeout* is zero or negative.  This takes care of that.

Props to @aaliddell for noticing the inconsistency..
(cherry picked from commit c517fc7)

Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
1st1 pushed a commit that referenced this pull request Aug 26, 2020
@elprans
[3.8] bpo-32751: Wait for task cancel in asyncio.wait_for() when time… …
57b6988 
…out <= 0 (GH-21895) (#21967)

When I was fixing bpo-32751 back in GH-7216 I missed the case when
*timeout* is zero or negative.  This takes care of that.

Props to @aaliddell for noticing the inconsistency..
(cherry picked from commit c517fc7)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@elprans @xzy3-cdc
bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <=… …
21285ef 
… 0 (python#21895)

When I was fixing bpo-32751 back in pythonGH-7216 I missed the case when
*timeout* is zero or negative.  This takes care of that.

Props to @aaliddell for noticing the inconsistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

@1st1 1st1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@elprans @1st1 @miss-islington @bedevere-bot @the-knights-who-say-ni