◐ Shell
reader mode source ↗
Skip to content

[doc] Add link to FileHandler in logging (GH-21940)#21940

Merged
vsajip merged 5 commits into
python:masterfrom
andresdelfino:add_link_to_filehandler
Sep 1, 2020
Merged

[doc] Add link to FileHandler in logging (GH-21940)#21940
vsajip merged 5 commits into
python:masterfrom
andresdelfino:add_link_to_filehandler

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Aug 22, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

No link exists in the doc

Automerge-Triggered-By: @vsajip

@andresdelfino andresdelfino requested a review from vsajip as a code owner August 22, 2020 14:39
vsajip
vsajip requested changes Aug 23, 2020
View reviewed changes

@vsajip vsajip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The table contains numerous other references to FileHandler and StreamHandler - I would suggest changing them all to cross-references, or leaving them all as is.

@bedevere-bot

bedevere-bot commented Aug 23, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andresdelfino

andresdelfino commented Aug 23, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @vsajip I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Aug 23, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from vsajip August 23, 2020 15:00
vsajip
vsajip requested changes Aug 31, 2020
View reviewed changes

@vsajip vsajip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Apparently there are conflicts - please resolve.

@bedevere-bot

bedevere-bot commented Aug 31, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andresdelfino

andresdelfino commented Aug 31, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Aug 31, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from vsajip August 31, 2020 18:02
@andresdelfino

andresdelfino commented Aug 31, 2020

Copy link
Copy Markdown
Contributor Author

For some reason, make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W --keep-going -j4" doctest suspicious html is not using the created venv.

make htmlview works correctly locally.

@vsajip

vsajip commented Sep 1, 2020

Copy link
Copy Markdown
Member

I'll close and reopen the pull request to see if that makes a difference.

@vsajip vsajip closed this Sep 1, 2020
@vsajip vsajip reopened this Sep 1, 2020
@vsajip vsajip changed the title [doc] Add link to FileHandler in logging Sep 1, 2020
@vsajip vsajip merged commit f5a16b4 into python:master Sep 1, 2020
@andresdelfino andresdelfino deleted the add_link_to_filehandler branch September 1, 2020 13:02
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@andresdelfino @adelfino-ona @xzy3-cdc
[doc] Add link to FileHandler in logging (pythonGH-21940) …
d5838e8 
Co-authored-by: Andrés Delfino <adelfino@onapsis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andresdelfino @bedevere-bot @vsajip @the-knights-who-say-ni @adelfino-ona