{{ message }}
bpo-27485: Rename and deprecate undocumented functions in urllib.parse#2205
Merged
ambv merged 4 commits intoApr 25, 2018
Merged
bpo-27485: Rename and deprecate undocumented functions in urllib.parse#2205ambv merged 4 commits into
ambv merged 4 commits into
Conversation
Contributor
Sorry, something went wrong.
vadmium
reviewed
Jul 2, 2017
Contributor
|
Looks like this unfortunately didn't make it into 3.7. There's a conflict that would need to be solved and the deprecation messages would need to be renamed to mention "3.8". |
Sorry, something went wrong.
Contributor
Author
|
@ambv Thank you for the review. I've rebased and updated the deprecation messages to reference 3.8 instead of 3.7. |
Sorry, something went wrong.
Contributor
|
Thanks! ✨ 🍰 ✨ |
Sorry, something went wrong.
behnam
reviewed
Aug 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The following functions were undocumented:
splitattr,splithost,splitnport,splitpasswd,splitport,splitquery,splittag,splittype,splituser,splitvalue,to_bytes,unwrapA note in the 2.7 documentation for
urllibstated that Python 3 does not expose these helper functions, but yet they were still available.https://bugs.python.org/issue27485