◐ Shell
reader mode source ↗
Skip to content

bpo-41747: Ensure all dataclass methods uses their parents' qualname#22155

Merged
ericvsmith merged 5 commits into
python:masterfrom
isidentical:bpo-41747
Oct 21, 2020
Merged

bpo-41747: Ensure all dataclass methods uses their parents' qualname#22155
ericvsmith merged 5 commits into
python:masterfrom
isidentical:bpo-41747

Conversation

@isidentical

@isidentical isidentical commented Sep 8, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal
pablogsal approved these changes Sep 8, 2020
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This LGTM but it would be great if @ericvsmith could take a final look

@bedevere-bot

bedevere-bot commented Sep 8, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ericvsmith ericvsmith self-assigned this Sep 8, 2020
@serhiy-storchaka serhiy-storchaka self-requested a review September 9, 2020 06:31
serhiy-storchaka
serhiy-storchaka reviewed Sep 9, 2020
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Seems this change also makes these methods pickleable.

@isidentical @serhiy-storchaka
escape dot …
e222153 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
serhiy-storchaka approved these changes Sep 9, 2020
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

👍

ericvsmith
ericvsmith requested changes Sep 9, 2020
View reviewed changes

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

With a few tiny issues, this looks good to me.

@serhiy-storchaka: Should we also add tests for pickling these methods? Or should that be another PR?

@bedevere-bot

bedevere-bot commented Sep 9, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@serhiy-storchaka

serhiy-storchaka commented Sep 9, 2020

Copy link
Copy Markdown
Member

I do not think that it is necessary to add tests for pickling these methods.

@isidentical

isidentical commented Oct 18, 2020

Copy link
Copy Markdown
Member Author

@ericvsmith a gentle ping.

@ericvsmith

ericvsmith commented Oct 18, 2020

Copy link
Copy Markdown
Member

Sorry for the delays. This is on my list of things to look at next week during the development sprints.

@ericvsmith ericvsmith merged commit c7437e2 into python:master Oct 21, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@isidentical @serhiy-storchaka @adorilson
bpo-41747: Ensure all dataclass methods uses their parents' qualname (p… …
6b5944e 
…ythonGH-22155)

* bpo-41747: Ensure all dataclass methods uses their parents' qualname

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@LewisGaul LewisGaul mentioned this pull request Mar 24, 2021
Merged
@isidentical isidentical mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith

@serhiy-storchaka serhiy-storchaka

@pablogsal pablogsal pablogsal approved these changes

Assignees

@ericvsmith ericvsmith

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@isidentical @bedevere-bot @serhiy-storchaka @ericvsmith @pablogsal @the-knights-who-say-ni