◐ Shell
reader mode source ↗
Skip to content

bpo-41052: Optout serialization/deserialization for blake2s/b#22189

Closed
corona10 wants to merge 1 commit into
python:masterfrom
corona10:bpo-41052-blake2
Closed

bpo-41052: Optout serialization/deserialization for blake2s/b#22189
corona10 wants to merge 1 commit into
python:masterfrom
corona10:bpo-41052-blake2

Conversation

@corona10

@corona10 corona10 commented Sep 10, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10 corona10 requested a review from vstinner September 10, 2020 14:48
@corona10 corona10 requested a review from tiran as a code owner September 10, 2020 14:48
@corona10

corona10 commented Sep 10, 2020

Copy link
Copy Markdown
Member Author

Before heap types, serialization/deserialization was failed.

serhiy-storchaka
serhiy-storchaka reviewed Sep 10, 2020
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

By default most extension types are not serializable. blake2b is not serializable. Why is it needed to add explicit __reduce__ method?

@corona10

corona10 commented Sep 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@serhiy-storchaka

master (after #21856)

Python 3.10.0a0 (heads/master:f76d894dc5, Sep 10 2020, 23:26:39)
[Clang 11.0.0 (clang-1100.0.33.12)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import pickle
>>> import _blake2
>>> pickle.dumps(_blake2.blake2s(), 0)
b'ccopy_reg\n_reconstructor\np0\n(c_blake2\nblake2s\np1\nc__builtin__\nobject\np2\nNtp3\nRp4\n.'
>>> pickle.dumps(_blake2.blake2s(), 1)
b'ccopy_reg\n_reconstructor\nq\x00(c_blake2\nblake2s\nq\x01c__builtin__\nobject\nq\x02Ntq\x03Rq\x04.'

before

>>> import _blake2
>>> import pickle
>>> pickle.dumps(_blake2.blake2s(), 0)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/copyreg.py", line 65, in _reduce_ex
    raise TypeError("can't pickle %s objects" % base.__name__)
TypeError: can't pickle blake2s objects
>>> pickle.dumps(_blake2.blake2s(), 1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/copyreg.py", line 65, in _reduce_ex
    raise TypeError("can't pickle %s objects" % base.__name__)
TypeError: can't pickle blake2s objects

@corona10

corona10 commented Sep 10, 2020

Copy link
Copy Markdown
Member Author

I created the issue https://bugs.python.org/issue41052 when I found the issue after porting to heap type.

@serhiy-storchaka

serhiy-storchaka commented Nov 21, 2020

Copy link
Copy Markdown
Member

This is no longer needed, is not?

@corona10

corona10 commented Nov 23, 2020

Copy link
Copy Markdown
Member Author

@serhiy-storchaka Yeah this pr is no needed ;)

@corona10 corona10 closed this Nov 23, 2020
@corona10 corona10 deleted the bpo-41052-blake2 branch November 23, 2020 07:22
@vstinner

vstinner commented Nov 23, 2020

Copy link
Copy Markdown
Member

This is no longer needed, is not?

Cool. I like the fact that it's no longer needed thanks to the generic https://bugs.python.org/issue41052 fix :-D Thanks again for the generic fix! It's way better than such copy/paste fix on each type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@shihai1991 shihai1991 shihai1991 left review comments

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10 @serhiy-storchaka @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot