◐ Shell
reader mode source ↗
Skip to content

bpo-41790: update error in documentation#22242

Open
koubaa wants to merge 1 commit into
python:mainfrom
koubaa:bpo-1635741-doc
Open

bpo-41790: update error in documentation#22242
koubaa wants to merge 1 commit into
python:mainfrom
koubaa:bpo-1635741-doc

Conversation

@koubaa

@koubaa koubaa commented Sep 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 14, 2020
@koubaa

koubaa commented Sep 14, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @corona10 @shihai1991 I'm sure I have the wrong issue number but wanted to propose this change to the doc. I can change the number and rebase.

@vstinner

vstinner commented Sep 14, 2020

Copy link
Copy Markdown
Member

@vstinner @corona10 @shihai1991 I'm sure I have the wrong issue number but wanted to propose this change to the doc. I can change the number and rebase.

You have the wrong issue number.

@koubaa koubaa changed the title bpo-1635741: update error in documentation Sep 15, 2020
@koubaa

koubaa commented Sep 15, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner @corona10 @shihai1991 I'm sure I have the wrong issue number but wanted to propose this change to the doc. I can change the number and rebase.

You have the wrong issue number.

@vstinner I made a new issue in that case.

eamanu
eamanu approved these changes Sep 16, 2020
View reviewed changes

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@koubaa

koubaa commented Sep 20, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner is anything else needed before merging this?

@koubaa

koubaa commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner bump

@KrisThielemans KrisThielemans mentioned this pull request Apr 18, 2022
Closed
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
iritkatriel
iritkatriel requested changes Dec 6, 2022
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This has merge conflicts now.

@bedevere-bot

bedevere-bot commented Dec 6, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@koubaa koubaa mannequin mentioned this pull request Jan 12, 2024
Open
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@encukou encukou encukou left review comments

@shihai1991 shihai1991 shihai1991 left review comments

@erlend-aasland erlend-aasland erlend-aasland left review comments

@iritkatriel iritkatriel iritkatriel requested changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes docs skip news stale Stale PR or inactive for long period of time.

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@koubaa @vstinner @bedevere-bot @encukou @iritkatriel @eamanu @shihai1991 @erlend-aasland @the-knights-who-say-ni @ezio-melotti