◐ Shell
reader mode source ↗
Skip to content

bpo-1635741: Port _csv to multi-phase init#22838

Closed
encukou wants to merge 2 commits into
python:masterfrom
encukou:pep-573-walker-and-csv
Closed

bpo-1635741: Port _csv to multi-phase init#22838
encukou wants to merge 2 commits into
python:masterfrom
encukou:pep-573-walker-and-csv

Conversation

@encukou

@encukou encukou commented Oct 20, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This PR depends on #22835 and shows how the new _PyType_GetModuleByDef can be used. I would love these to go in as two separate commits.

https://bugs.python.org/issue1635741

encukou and others added 2 commits October 20, 2020 22:45
@encukou
Add _PyType_GetModuleByDef
0b0d93c
@encukou @eduardo-elizondo @shihai1991
Remove static state from the _csv module …
7b33be1 
Uses code from: python#16078

Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com>
Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
Co-authored-by: Hai Shi <shihai1992@gmail.com>
This was referenced Oct 20, 2020
Merged
Closed
@encukou encukou marked this pull request as ready for review November 10, 2020 13:51
@encukou encukou requested a review from markshannon as a code owner November 10, 2020 13:51
@encukou encukou changed the base branch from master to 3.9 November 10, 2020 13:53
@encukou encukou requested review from a team, vsajip and warsaw as code owners November 10, 2020 13:53
@encukou encukou changed the base branch from 3.9 to master November 10, 2020 13:53
@encukou

encukou commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

Apologies for the mass review requests. I'll open a new PR.

@encukou encukou closed this Nov 10, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon

@1st1 1st1 Awaiting requested review from 1st1

@abalkin abalkin Awaiting requested review from abalkin

@asvetlov asvetlov Awaiting requested review from asvetlov

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@brettcannon brettcannon Awaiting requested review from brettcannon

@ericsnowcurrently ericsnowcurrently

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

@gpshead gpshead Awaiting requested review from gpshead

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

@methane methane Awaiting requested review from methane

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@pablogsal pablogsal Awaiting requested review from pablogsal

@pganssle pganssle Awaiting requested review from pganssle

@rhettinger rhettinger Awaiting requested review from rhettinger

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

@tiran tiran Awaiting requested review from tiran

@vsajip vsajip Awaiting requested review from vsajip

@warsaw warsaw Awaiting requested review from warsaw

1 more reviewer

@koubaa koubaa koubaa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou @koubaa @the-knights-who-say-ni @bedevere-bot