Gotcha. Yeah, I was referring to the next alpha, scheduled for 3/1. I thought maybe you might need a day or two between tagging and releasing or something.

I thought maybe you might need a day or two between tagging and releasing or something.

No, although is a multi-hour process, I normally do it on the same day as the release, at least for the alphas (assuming everything goes smoothly).

found a bit of an odd case while trying this out -- not sure if it's intentional:

x = 1

match x:
    case 1 as y if 0:
        print('unreachable')
print(f'{y=}')  # expect NameError

instead of NameError I get y=1

found a bit of an odd case while trying this out -- not sure if it's intentional:

x = 1

match x:
    case 1 as y if 0:
        print('unreachable')
print(f'{y=}')  # expect NameError

instead of NameError I get y=1

IIRC I think that is covered in https://www.python.org/dev/peps/pep-0634/#side-effects-and-undefined-behavior, although the peephole could detect the branch and optimize it away.

Yeah, we're required to bind any names used by the guard before evaluating it (obviously). The current naive implementation accomplishes this by binding all names before hitting any guard. Strange example, but legal by the PEP.

I'm actually not sure the peephole/CFG could catch this (it can optimize out the body of the case, though, and it actually does here). Might be something for the AST optimizer.

I believe I have addressed all of the comments so far. If anyone still has additional feedback (or needs the weekend to review), please let me know. Otherwise, I'll plan on merging this Friday.

@pablogsal, should we hit it with the buildbots again?

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 61616fc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

The three failed jobs look unrelated to these changes; I see the same failures (with the same logs) on #24643.

Okay, I'm going to merge this. 🍾

Big thanks to everyone who took time to help out here!