{{ message }}
[Security] bpo-30713: Reject newline in urllib.parse#2303
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
Member
Sorry, something went wrong.
The splittype(), splitport() and splithost() functions of the urllib.parse module now reject URLs which contain a newline character.
Member
|
Sorry @Haypo, I think newlines are a special case in some regular expression implementations, but I don’t remember the details for Python, so it is not clear to me what your code will do. I trust Serhiy has better knowledge with regular expressions :) |
Sorry, something went wrong.
Member
Author
|
https://bugs.python.org/issue29606 was fixed in ftplib. urllib is not the right place to reject invalid inputs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The splittype(), splitport() and splithost() functions of the
urllib.parse module now reject URLs which contain a newline
character.