◐ Shell
reader mode source ↗
Skip to content

bpo-30723: Enhancement to IDLE parenmatch extension#2306

Merged
terryjreedy merged 8 commits into
python:masterfrom
wohlganger:parens
Jun 28, 2017
Merged

bpo-30723: Enhancement to IDLE parenmatch extension#2306
terryjreedy merged 8 commits into
python:masterfrom
wohlganger:parens

Conversation

@wohlganger

@wohlganger wohlganger commented Jun 20, 2017

Copy link
Copy Markdown
Contributor

added highlight both parens option.
added name to acks file.

trivial - made FLASH_DELAY configure for all styles. …
1700630 
added highlight both parens option.
@mention-bot

mention-bot commented Jun 20, 2017

Copy link
Copy Markdown

@wohlganger, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @Yhg1s to be potential reviewers.

@wohlganger wohlganger changed the title trivial - made FLASH_DELAY configure for all styles. Jun 20, 2017
@mlouielu

mlouielu commented Jun 21, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

I think this changed isn't trivial, you will need to first add the issue on bugs.python.org. Nosy @terryjreedy for this is a IDLE PR.

@mlouielu mlouielu mentioned this pull request Jun 21, 2017
Closed
@wohlganger

wohlganger commented Jun 21, 2017

Copy link
Copy Markdown
Contributor Author

Added to bugs.python.org . ID# 30723

@terryjreedy terryjreedy self-requested a review June 21, 2017 19:53
@terryjreedy terryjreedy self-assigned this Jun 21, 2017
@terryjreedy terryjreedy changed the title "trivial" - made FLASH_DELAY configure for all styles. Jun 21, 2017
@wohlganger

wohlganger commented Jun 27, 2017

Copy link
Copy Markdown
Contributor Author

Minor change committed to fix conflict with bpo-29910.

terryjreedy
terryjreedy requested changes Jun 27, 2017
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I made comments about the initial PR on bpo-30723 and made desired changes myself. Still need news.

@terryjreedy terryjreedy merged commit fae2c35 into python:master Jun 28, 2017
terryjreedy pushed a commit to terryjreedy/cpython that referenced this pull request Jun 28, 2017
@wohlganger @terryjreedy
[3.6] bpo-30723: IDLE -- Enhance parenmatch; add style, flash, and he… …
990c8e3 
…lp (pythonGH-2306)

* Add 'parens' style to highlight both opener and closer.
* Make 'default' style, which is not default, a synonym for 'opener'.
* Make time-delay work the same with all styles.
* Add help for config dialog extensions tab, including parenmatch.
* Add new tests.
Original patch by Charles Wohlganger.
(cherry picked from commit fae2c35)
@terryjreedy terryjreedy mentioned this pull request Jun 28, 2017
Merged
terryjreedy added a commit that referenced this pull request Jun 28, 2017
@terryjreedy
[3.6] bpo-30723: IDLE -- Enhance parenmatch; add style, flash, and he… …
af68382 
…lp (GH-2306) (#2460)

* Add 'parens' style to highlight both opener and closer.
* Make 'default' style, which is not default, a synonym for 'opener'.
* Make time-delay work the same with all styles.
* Add help for config dialog extensions tab, including parenmatch.
* Add new tests.
Original patch by Charles Wohlganger.
(cherry picked from commit fae2c35)
@wohlganger wohlganger deleted the parens branch June 28, 2017 12:58
@mlouielu mlouielu mentioned this pull request Aug 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

@terryjreedy terryjreedy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wohlganger @mention-bot @mlouielu @terryjreedy @the-knights-who-say-ni