{{ message }}
bpo-29591: [2.7] Update VS project files#2310
Merged
vstinner merged 1 commit intoJun 21, 2017
Merged
Conversation
Contributor
Sorry, something went wrong.
vstinner
reviewed
Jun 21, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Can you please elaborate the commit message to list removed define and explain that they are now already defined in Modules/expat/winconfig.h?
Sorry, something went wrong.
Member
|
The overall change LGTM, except of my (minor) comments. Can you please rebase it since I just merged my expat 2.2.1 change? |
Sorry, something went wrong.
jkloth
force-pushed
the
issue29591-expat-2.2.0
branch
from
6782ae7 to
80aa260
Compare
June 21, 2017 17:55
* Silence warnings caused by duplicated defines from Modules\expat\winconfig.h * Add WIN32 define to VS9.0 project files to match MSBuild project files.
jkloth
force-pushed
the
issue29591-expat-2.2.0
branch
from
80aa260 to
153dfe6
Compare
June 21, 2017 18:00
Contributor
Author
|
Rebased and modified commit message. |
Sorry, something went wrong.
Member
|
The ch1nge looks safe and should at least fix the HAVE_MEMMOVE warning. Thanks. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Updates the Visual Studio project files to fix regressions due to Expat 2.2.0