bpo-40077: Convert _queuemodule to use heap types#23136
Conversation
8ae2983 to
5966894
Compare
November 3, 2020 22:53
|
FYI, rebased onto master, applied |
Sorry, something went wrong.
|
I have made the requested changes; please review again. |
Sorry, something went wrong.
|
Thanks for making the requested changes! : please review the changes made to this pull request. |
Sorry, something went wrong.
pitrou
left a comment
There was a problem hiding this comment.
+1, thank you @erlend-aasland
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x RHEL8 LTO + PGO 3.x has failed when building commit 01c6aa4. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/442/builds/671 Summary of the results of the build (if available): == Tests result: ENV CHANGED == 409 tests OK. 10 slowest tests:
1 test altered the execution environment: 15 tests skipped: Total duration: 4 min 54 sec Click to see traceback logsTraceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 321, in __del__
self.close()
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 316, in close
self._ssl_protocol._start_shutdown()
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
self._abort()
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 731, in _abort
self._transport.abort()
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/selector_events.py", line 680, in abort
self._force_close(None)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/selector_events.py", line 731, in _force_close
self._loop.call_soon(self._call_connection_lost, exc)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/base_events.py", line 746, in call_soon
self._check_closed()
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/base_events.py", line 510, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
|
Sorry, something went wrong.
The typo did no damage, but it looks suspicious and confusing. Introduced by pythonGH-23136.
The typo did no damage, but it looks suspicious and confusing. Introduced by pythonGH-23136. Skip news. Automerge-Triggered-By: GH:pitrou
|
@pitrou: You merged the commit message with the sentence: And I'm now getting emails from cpython forks, like this commit: |
Sorry, something went wrong.
|
Ah, sorry. I get this sometimes when my name is mentioned too :-) |
Sorry, something went wrong.
Well, the "automerge" label causes a similar feature and it's part of our workflow. I'm not sure how to ignore such emails. @pganssle has such issue: https://twitter.com/pganssle/status/1379161385863643155 |
Sorry, something went wrong.
|
It's partly my fault; I cc'd you in the PR text instead of in a separate comment/post. After this incident, I've made sure I don't mention anyone in the PR text. Maybe it could be mentioned in the Dev Guide? Maybe we could make the CI prevent it by rewriting the commit message (if needed) upon merging. |
Sorry, something went wrong.
|
I asked how to not get spammed on python-committers: https://mail.python.org/archives/list/python-committers@python.org/thread/OCVQ6IYOVTVYW7ADDNOHKR7JDRBYLM3T/ |
Sorry, something went wrong.
@vstinner / @corona10, would you mind reviewing this?
https://bugs.python.org/issue40077
Automerge-Triggered-By: GH:pitrou