◐ Shell
reader mode source ↗
Skip to content

bpo-30730: Prevent environment variables injection in subprocess on Windows.#2325

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
serhiy-storchaka:env-var-injection
Jun 23, 2017
Merged

bpo-30730: Prevent environment variables injection in subprocess on Windows.#2325
serhiy-storchaka merged 3 commits into
python:masterfrom
serhiy-storchaka:env-var-injection

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 22, 2017

Copy link
Copy Markdown
Member

Prevent passing other environment variables and command arguments.

@serhiy-storchaka
bpo-30730: Prevent environment variables injection in subprocess on W… …
5c9d576 
…indows.

Prevent passing other environment variables and command arguments.
@serhiy-storchaka serhiy-storchaka merged commit d174d24 into python:master Jun 23, 2017
@serhiy-storchaka serhiy-storchaka deleted the env-var-injection branch June 23, 2017 16:39
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 23, 2017
@serhiy-storchaka
[3.6] bpo-30730: Prevent environment variables injection in subproces… …
b27031f 
…s on Windows. (pythonGH-2325)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
@bedevere-bot

bedevere-bot commented Jun 23, 2017

Copy link
Copy Markdown

GH-2360 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 23, 2017
@serhiy-storchaka
[3.5] bpo-30730: Prevent environment variables injection in subproces… …
d9f2cab 
…s on Windows. (pythonGH-2325)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
@bedevere-bot

bedevere-bot commented Jun 23, 2017

Copy link
Copy Markdown

GH-2361 is a backport of this pull request to the 3.5 branch.

serhiy-storchaka added a commit that referenced this pull request Jun 23, 2017
@serhiy-storchaka
[3.6] bpo-30730: Prevent environment variables injection in subproces… …
e713575 
…s on Windows. (GH-2325) (#2360)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
serhiy-storchaka added a commit that referenced this pull request Jun 23, 2017
@serhiy-storchaka
[3.5] bpo-30730: Prevent environment variables injection in subproces… …
a7c0264 
…s on Windows. (GH-2325) (#2361)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 24, 2017
@serhiy-storchaka
[2.7] bpo-30730: Prevent environment variables injection in subproces… …
30e5cf2 
…s on Windows. (pythonGH-2325)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
@bedevere-bot

bedevere-bot commented Jun 24, 2017

Copy link
Copy Markdown

GH-2372 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka added a commit that referenced this pull request Jun 24, 2017
@serhiy-storchaka
[2.7] bpo-30730: Prevent environment variables injection in subproces… …
9dda2ca 
…s on Windows. (GH-2325) (#2372)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 24, 2017
@serhiy-storchaka
[3.4] bpo-30730: Prevent environment variables injection in subproces… …
1be314a 
…s on Windows. (pythonGH-2325)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 24, 2017
@serhiy-storchaka
[3.3] bpo-30730: Prevent environment variables injection in subproces… …
84bfcb8 
…s on Windows. (pythonGH-2325)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Jul 7, 2017
@serhiy-storchaka @ned-deily
[3.6] bpo-30730: Prevent environment variables injection in subproces… …
a9b16cf 
…s on Windows. (pythonGH-2325) (python#2360)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
(cherry picked from commit e713575)
larryhastings pushed a commit that referenced this pull request Jul 11, 2017
@serhiy-storchaka @larryhastings
[security][3.4] bpo-30730: Prevent environment variables injection in… …
fe82c46 
… subprocess on Windows. (GH-2325) (#2362)

* [3.4] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)

* Update NEWS
ned-deily pushed a commit that referenced this pull request Jul 19, 2017
@serhiy-storchaka @ned-deily
[security][3.3] bpo-30730: Prevent environment variables injection in… …
e46f1c1 
… subprocess on Windows. (GH-2325) (#2363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun left review comments

+1 more reviewer

@mattip mattip mattip left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OS-windows type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @bedevere-bot @mattip @eryksun @the-knights-who-say-ni