◐ Shell
reader mode source ↗
Skip to content

bpo-42361: Use Tcl/Tk 8.6.10 when building the installer on recent macOS#23293

Merged
miss-islington merged 1 commit into
python:masterfrom
ronaldoussoren:bpo-42361
Nov 22, 2020
Merged

bpo-42361: Use Tcl/Tk 8.6.10 when building the installer on recent macOS#23293
miss-islington merged 1 commit into
python:masterfrom
ronaldoussoren:bpo-42361

Conversation

@ronaldoussoren

@ronaldoussoren ronaldoussoren commented Nov 15, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.

https://bugs.python.org/issue42361

Automerge-Triggered-By: GH:ned-deily

@ronaldoussoren
bpo-42361: Use Tcl/Tk 8.6.10 when building the instalelr on recent macOS …
d361777 
Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.
@ronaldoussoren ronaldoussoren requested a review from a team as a code owner November 15, 2020 12:39
@ronaldoussoren ronaldoussoren self-assigned this Nov 15, 2020
@bedevere-bot bedevere-bot added the label Nov 15, 2020
ned-deily
ned-deily approved these changes Nov 15, 2020
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM in principle

@miss-islington miss-islington merged commit 690a5fa into python:master Nov 22, 2020
@miss-islington

miss-islington commented Nov 22, 2020

Copy link
Copy Markdown
Contributor

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 22, 2020

Copy link
Copy Markdown
Contributor

Sorry, @ronaldoussoren, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 690a5fa3ddc675a434730b057ddb5c33f44fd0b7 3.9

@miss-islington

miss-islington commented Nov 22, 2020

Copy link
Copy Markdown
Contributor

Sorry @ronaldoussoren, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 690a5fa3ddc675a434730b057ddb5c33f44fd0b7 3.8

@ned-deily

ned-deily commented Nov 22, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Note, the merge conflict for 3.9 should disappear after the merge of GH-23295, the 3.9 backport of bpo-41100, macOS Big Sur and Apple Silicon Macs support.

@miss-islington

miss-islington commented Nov 22, 2020

Copy link
Copy Markdown
Contributor

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 22, 2020

Copy link
Copy Markdown

GH-23465 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 22, 2020
@ronaldoussoren @miss-islington
bpo-42361: Use Tcl/Tk 8.6.10 when building the installer on recent ma… …
961e929 
…cOS (pythonGH-23293)

Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.
(cherry picked from commit 690a5fa)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
miss-islington added a commit that referenced this pull request Nov 22, 2020
@miss-islington @ronaldoussoren
bpo-42361: Use Tcl/Tk 8.6.10 when building the installer on recent ma… …
8572059 
…cOS (GH-23293)

Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.
(cherry picked from commit 690a5fa)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ronaldoussoren @adorilson
bpo-42361: Use Tcl/Tk 8.6.10 when building the installer on recent ma… …
c721486 
…cOS (pythonGH-23293)

Building on older versions, and in particular macOS 10.9 still use
Tk 8.6.8 because of build problems on that version of macOS.
@erlend-aasland erlend-aasland mentioned this pull request Jul 30, 2022
Closed
@ronaldoussoren ronaldoussoren mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees

@miss-islington miss-islington

Labels

OS-mac skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronaldoussoren @miss-islington @ned-deily @bedevere-bot @the-knights-who-say-ni