◐ Shell
reader mode source ↗
Skip to content

bpo-41861: Add NEWS and normalise _sqlite3 Cache/Node type struct naming#23337

Merged
vstinner merged 3 commits into
python:masterfrom
erlend-aasland:bpo-41861/final
Nov 17, 2020
Merged

bpo-41861: Add NEWS and normalise _sqlite3 Cache/Node type struct naming#23337
vstinner merged 3 commits into
python:masterfrom
erlend-aasland:bpo-41861/final

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor Author

@corona10 Would you mind taking a quick look at this? Just closing bpo-41861 by adding a NEWS entry and normalising Cache/Node struct names (so that the naming is consistent with the other type structs in _sqlite3.)

(I closed #22419, since it went in limbo.)

corona10
corona10 reviewed Nov 17, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

@erlend-aasland

Can you provide a discussion about normalizing?
we often do not accept this kind of PR ;)

@erlend-aasland

erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor Author

Can you provide a discussion about normalizing?
we often do not accept this kind of PR ;)

Yes, I'm aware of that, but since this is the final PR of bpo-41861, I thought an exception would be acceptable, since the other PR's relating to this bpo have used this naming scheme ;) Please? :)

@vstinner
Fix punctuation mark in NEWS entry …
f268153 
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner merged commit 2ffba2a into python:master Nov 17, 2020
@vstinner

vstinner commented Nov 17, 2020

Copy link
Copy Markdown
Member

Merged. I rewrote your commit message to make it shorter.

@erlend-aasland erlend-aasland deleted the bpo-41861/final branch November 17, 2020 13:32
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-41861, _sqlite3 : Add NEWS entry and rename variables (pythonGH-2… …
b989296 
…3337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@corona10 corona10 corona10 left review comments

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @vstinner @corona10 @the-knights-who-say-ni @bedevere-bot