◐ Shell
reader mode source ↗
Skip to content

bpo-42384: pdb: correctly populate sys.path[0]#23338

Merged
miss-islington merged 3 commits into
python:masterfrom
hexagonrecursion:fix-issue42383-and-issue42384
Jan 22, 2021
Merged

bpo-42384: pdb: correctly populate sys.path[0]#23338
miss-islington merged 3 commits into
python:masterfrom
hexagonrecursion:fix-issue42383-and-issue42384

Conversation

@hexagonrecursion

@hexagonrecursion hexagonrecursion commented Nov 17, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42384

Automerge-Triggered-By: GH:gvanrossum

@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
@hexagonrecursion

This comment has been minimized.

Sign in to view
@shihai1991

shihai1991 commented Nov 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

The new tests I added fail on Windows. I'll fix them later.

Thanks for your contribute, Looks like you need sign the CLA :)

@hexagonrecursion

This comment has been minimized.

Sign in to view
@hexagonrecursion hexagonrecursion changed the title bpo-42383 and bpo-42384: pdb: reexecute the right file even if the current directory changes and correctly populate sys.path[0] Nov 19, 2020
@hexagonrecursion

hexagonrecursion commented Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

Following this instructions

#23338 (comment)

My personal experience(NOT the official way):

* Creating the first PR to solve the fist issue you want fixed.

* After the first PR merged, we can add some description info in second issue, something like: `After PR-XXX merged, this issue should be resolved by the way.`. MAYBE you can create an another PR to add the testcase of the second issue.

I have updated the pull request.

@hexagonrecursion hexagonrecursion mentioned this pull request Nov 19, 2020
Merged
@github-actions

github-actions Bot commented Dec 20, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 20, 2020
@gvanrossum

gvanrossum commented Dec 22, 2020

Copy link
Copy Markdown
Member

This looks like the original behavior is just a bug (I think maybe far in the past the path value was always relative) and I am okay with backporting to 3.8 and 3.9.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 23, 2020
@github-actions

github-actions Bot commented Jan 22, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 22, 2021
@miss-islington miss-islington merged commit 8603dfb into python:master Jan 22, 2021
@miss-islington

miss-islington commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

Thanks @hexagonrecursion for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

16 hidden items Load more…
@bedevere-bot

bedevere-bot commented Jan 22, 2021

Copy link
Copy Markdown

GH-24290 is a backport of this pull request to the 3.9 branch.

@bedevere-bot

bedevere-bot commented Jan 22, 2021

Copy link
Copy Markdown

GH-24291 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2021
@hexagonrecursion @miss-islington
bpo-42384: pdb: correctly populate sys.path[0] (pythonGH-23338) …
1392e78 
Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit 8603dfb)

Co-authored-by: Andrey Bienkowski <hexagonrecursion@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2021
@hexagonrecursion @miss-islington
bpo-42384: pdb: correctly populate sys.path[0] (pythonGH-23338) …
72ed9fe 
Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit 8603dfb)

Co-authored-by: Andrey Bienkowski <hexagonrecursion@gmail.com>
@shihai1991

shihai1991 commented Jan 22, 2021

Copy link
Copy Markdown
Member

Thanks Andrey for your contirbute.
Thanks Guido for your review.

@hexagonrecursion hexagonrecursion deleted the fix-issue42383-and-issue42384 branch January 24, 2021 16:38
This was referenced Jan 25, 2021
Merged
Merged
gvanrossum pushed a commit that referenced this pull request Jan 25, 2021
@hexagonrecursion
[3.9] bpo-42384: pdb: correctly populate sys.path[0] (GH-23338) (#24321)
f2df795
gvanrossum pushed a commit that referenced this pull request Jan 25, 2021
@hexagonrecursion
[3.8] bpo-42384: pdb: correctly populate sys.path[0] (GH-23338) (#24320)
c10180e
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@hexagonrecursion @adorilson
bpo-42384: pdb: correctly populate sys.path[0] (pythonGH-23338) …
d5b73b2 
Automerge-Triggered-By: GH:gvanrossum
@johnslavik johnslavik mentioned this pull request Dec 5, 2025
Closed
@jaraco jaraco mentioned this pull request Dec 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shihai1991 shihai1991 shihai1991 left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hexagonrecursion @the-knights-who-say-ni @shihai1991 @gvanrossum @miss-islington @bedevere-bot