◐ Shell
reader mode source ↗
Skip to content

bpo-1635741: Port _queue to multiphase initialization#23376

Merged
miss-islington merged 2 commits into
python:masterfrom
tiran:bpo-1635741-queue
Nov 19, 2020
Merged

bpo-1635741: Port _queue to multiphase initialization#23376
miss-islington merged 2 commits into
python:masterfrom
tiran:bpo-1635741-queue

Conversation

@tiran

@tiran tiran commented Nov 18, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue1635741

Automerge-Triggered-By: GH:tiran

@tiran tiran requested a review from rhettinger as a code owner November 18, 2020 19:12
@tiran tiran requested review from corona10 and vstinner November 18, 2020 23:38
vstinner
vstinner approved these changes Nov 19, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. I suggest to use PyModule_AddObjectRef() to make the code even better :-)

@tiran tiran force-pushed the bpo-1635741-queue branch from 526b05a to c620a61 Compare November 19, 2020 07:51
@tiran tiran requested a review from vstinner November 19, 2020 07:52
vstinner
vstinner approved these changes Nov 19, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, thanks for the update.

@miss-islington

miss-islington commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 3094dd5 into python:master Nov 19, 2020
@bedevere-bot

bedevere-bot commented Nov 19, 2020

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.x has failed when building commit 3094dd5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/483/builds/403) and take a look at the build logs.
  4. Check if the failure is related to this commit (3094dd5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/483/builds/403

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

404 tests OK.

10 slowest tests:

  • test_cmd_line: 4 min 40 sec
  • test_concurrent_futures: 4 min 15 sec
  • test_multiprocessing_spawn: 2 min 38 sec
  • test_unparse: 2 min 37 sec
  • test_tokenize: 2 min 35 sec
  • test_multiprocessing_forkserver: 2 min 25 sec
  • test_asyncio: 1 min 39 sec
  • test_capi: 1 min 37 sec
  • test_multiprocessing_fork: 1 min 35 sec
  • test_subprocess: 1 min 32 sec

1 test altered the execution environment:
test_concurrent_futures

20 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_gdb test_idle test_ioctl
test_msilib test_ossaudiodev test_spwd test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 14 min 1 sec

Click to see traceback logs 
Traceback (most recent call last):
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <module>
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 116, in spawn_main
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 116, in spawn_main
    exitcode = _main(fd, parent_sentinel)
    exitcode = _main(fd, parent_sentinel)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 126, in _main
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 126, in _main
    self = reduction.pickle.load(from_parent)
    self = reduction.pickle.load(from_parent)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 110, in __setstate__
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 110, in __setstate__
    self._semlock = _multiprocessing.SemLock._rebuild(*state)
    self._semlock = _multiprocessing.SemLock._rebuild(*state)
FileNotFoundError: [Errno 2] No such file or directory
FileNotFoundError: [Errno 2] No such file or directory
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 116, in spawn_main
    exitcode = _main(fd, parent_sentinel)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/spawn.py", line 126, in _main
    self = reduction.pickle.load(from_parent)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 110, in __setstate__
    self._semlock = _multiprocessing.SemLock._rebuild(*state)
FileNotFoundError: [Errno 2] No such file or directory
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
Warning -- Dangling thread: <Thread(QueueFeederThread, started daemon 34420633600)>
Warning -- Dangling thread: <_MainThread(MainThread, started 34374492160)>
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
Warning -- Dangling thread: <_MainThread(MainThread, started 34374492160)>
Warning -- Dangling thread: <Thread(QueueFeederThread, started daemon 34420633600)>
/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 3 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
Warning -- Unraisable exception
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/util.py", line 224, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
FileNotFoundError: [Errno 2] No such file or directory
Warning -- Unraisable exception
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/util.py", line 224, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
FileNotFoundError: [Errno 2] No such file or directory
Warning -- Unraisable exception
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/util.py", line 224, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/multiprocessing/synchronize.py", line 87, in _cleanup
    sem_unlink(name)
FileNotFoundError: [Errno 2] No such file or directory

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@tiran @adorilson
bpo-1635741: Port _queue to multiphase initialization (pythonGH-23376) …
1bc7281 
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
@Moosems Moosems mentioned this pull request Aug 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

@corona10 corona10 Awaiting requested review from corona10

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni