◐ Shell
reader mode source ↗
Skip to content

bpo-31904: fix test_doctest.py failures for VxWorks#23419

Merged
gpshead merged 4 commits into
python:masterfrom
Wind-River:fix-issue-31904-doctest
Dec 4, 2020
Merged

bpo-31904: fix test_doctest.py failures for VxWorks#23419
gpshead merged 4 commits into
python:masterfrom
Wind-River:fix-issue-31904-doctest

Conversation

@pxinwr

@pxinwr pxinwr commented Nov 20, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

In test_CLI(), "print(normalize(err))" expects "No such file" which has the first letter n as capital. However VxWorks outputs 'no such file with the first letter n as lower case. So tuned accordingly.

https://bugs.python.org/issue31904

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Nov 20, 2020
@jstasiak

jstasiak commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

Is there a publicly and freely available VxWorks VM image that one could use to test this?

@pxinwr

pxinwr commented Nov 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Is there a publicly and freely available VxWorks VM image that one could use to test this?
Try VxWorks SDK: https://labs.windriver.com/downloads/wrsdk.html
See README there for how to run up Python.

@bedevere-bot

bedevere-bot commented Nov 28, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pxinwr pxinwr force-pushed the fix-issue-31904-doctest branch from 9fc6556 to 677894b Compare December 2, 2020 07:43
@pxinwr

pxinwr commented Dec 2, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Dec 2, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from gpshead December 2, 2020 07:45
@gpshead gpshead merged commit 8d4f57d into python:master Dec 4, 2020
@vstinner

vstinner commented Dec 4, 2020

Copy link
Copy Markdown
Member

Thanks for the update @pxinwr and thanks @gpshead for merging the change ;-)

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pxinwr @adorilson
bpo-31904: fix test_doctest.py failures for VxWorks (pythonGH-23419) …
1b8d000 
Fix test_doctest.py failures for VxWorks by avoiding exact error message checks. (better for everyone all around)
@pxinwr pxinwr deleted the fix-issue-31904-doctest branch May 7, 2021 07:42
@kuhlenough kuhlenough mannequin mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pxinwr @jstasiak @bedevere-bot @vstinner @gpshead @the-knights-who-say-ni