{{ message }}
bpo-15216: TextIOWrapper support change encoding after creation#2343
Merged
methane merged 12 commits intoDec 21, 2017
Merged
Conversation
Member
Sorry, something went wrong.
|
@methane, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @loewis to be potential reviewers. |
Sorry, something went wrong.
pitrou
reviewed
Jun 23, 2017
methane
force-pushed
the
reconfigure-encoding
branch
from
25b65fb to
6213e31
Compare
September 15, 2017 17:52
errors should be 'strict' when encoding is not None and errors is not passed.
It make C implementation complicated, and behavor seems inconsistent.
pitrou
reviewed
Dec 14, 2017
pitrou
reviewed
Dec 14, 2017
pitrou
reviewed
Dec 14, 2017
pitrou
reviewed
Dec 14, 2017
pitrou
reviewed
Dec 14, 2017
pitrou
reviewed
Dec 14, 2017
pitrou
reviewed
Dec 14, 2017
pitrou
approved these changes
Dec 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue15216