◐ Shell
reader mode source ↗
Skip to content

bpo-39529: Deprecate creating new event loop in asyncio.get_event_loop()#23554

Merged
serhiy-storchaka merged 12 commits into
python:masterfrom
serhiy-storchaka:asyncio-get_event_loop
Apr 25, 2021
Merged

bpo-39529: Deprecate creating new event loop in asyncio.get_event_loop()#23554
serhiy-storchaka merged 12 commits into
python:masterfrom
serhiy-storchaka:asyncio-get_event_loop

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 29, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement DO-NOT-MERGE labels Nov 29, 2020
@serhiy-storchaka

serhiy-storchaka commented Nov 29, 2020

Copy link
Copy Markdown
Member Author

It is a draft. Tests which use asyncio.gather(), asyncio.as_completed(), etc in synchronous code should be rewritten to call them in coroutines, and purposed tests for warnings and errors should be added.

asvetlov
asvetlov reviewed Nov 29, 2020
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good so far.

@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review December 6, 2020 18:26
@serhiy-storchaka

serhiy-storchaka commented Dec 6, 2020

Copy link
Copy Markdown
Member Author

Ready for review.

@serhiy-storchaka

serhiy-storchaka commented Dec 6, 2020

Copy link
Copy Markdown
Member Author

Please give attention to tests. This is the main part of the PR.

@rhettinger rhettinger removed their request for review December 19, 2020 04:30
@github-actions

github-actions Bot commented Jan 19, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 19, 2021
asvetlov
asvetlov approved these changes Apr 4, 2021
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, please go ahead.
Sorry for the very long review.

@serhiy-storchaka serhiy-storchaka merged commit 172c0f2 into python:master Apr 25, 2021
@serhiy-storchaka serhiy-storchaka deleted the asyncio-get_event_loop branch April 25, 2021 10:40
@tirkarthi tirkarthi mentioned this pull request May 7, 2021
Open
@serhiy-storchaka serhiy-storchaka removed the stale Stale PR or inactive for long period of time. label Aug 31, 2021
@asvetlov asvetlov mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov

@1st1 1st1 Awaiting requested review from 1st1

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @asvetlov @the-knights-who-say-ni @bedevere-bot