◐ Shell
reader mode source ↗
Skip to content

bpo-40939: Restore some stable API functions incorrectly deleted#23606

Merged
pablogsal merged 3 commits into
python:masterfrom
pablogsal:bpo-40939
Dec 2, 2020
Merged

bpo-40939: Restore some stable API functions incorrectly deleted#23606
pablogsal merged 3 commits into
python:masterfrom
pablogsal:bpo-40939

Conversation

@pablogsal

@pablogsal pablogsal commented Dec 2, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal requested a review from vstinner December 2, 2020 02:59
gvanrossum
gvanrossum reviewed Dec 2, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Shouldn't you also get rid of PyCompileString on line 1241? Because that's just a typo.

@pablogsal

pablogsal commented Dec 2, 2020

Copy link
Copy Markdown
Member Author

Shouldn't you also get rid of PyCompileString on line 1241? Because that's just a typo.

Done in 4989ebe

gvanrossum
gvanrossum approved these changes Dec 2, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Have you double checked that all these signatures match? (I haven't, I just trust that you know what you're doing. :-)

@pablogsal

pablogsal commented Dec 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Have you double checked that all these signatures match?

I have restored them as they were before the removal (so they should match whatever state they were in 3.8/3.9) and then I checked that all of them appear in Include/pythonrun.h (cross-match with 343ed0f) and that the signatures are correct. :)

@gvanrossum

gvanrossum commented Dec 2, 2020 via email

Copy link
Copy Markdown
Member

@pablogsal pablogsal merged commit 46bd5ed into python:master Dec 2, 2020
@pablogsal pablogsal deleted the bpo-40939 branch December 2, 2020 05:16
@python python deleted a comment from bedevere-bot Dec 2, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
bpo-40939: Restore some stable API functions incorrectly deleted (pyt… …
2bc30b3 
…honGH-23606)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @gvanrossum @the-knights-who-say-ni @bedevere-bot