◐ Shell
reader mode source ↗
Skip to content

bpo-30459: Cast the result of PyCell_SET to void#23654

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:pycell_set
Dec 7, 2020
Merged

bpo-30459: Cast the result of PyCell_SET to void#23654
vstinner merged 1 commit into
python:masterfrom
vstinner:pycell_set

Conversation

@vstinner

@vstinner vstinner commented Dec 5, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@vstinner vstinner mentioned this pull request Dec 5, 2020
Merged
@vstinner

vstinner commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: I rewrote the NEWS entry/What's New entry. Is it better?

@vstinner vstinner merged commit 0ef96c2 into python:master Dec 7, 2020
@vstinner

vstinner commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

Thanks for the review @serhiy-storchaka!

@vstinner vstinner deleted the pycell_set branch December 7, 2020 10:56
@serhiy-storchaka

serhiy-storchaka commented Dec 7, 2020

Copy link
Copy Markdown
Member

Thank you for catching the case of PyCell_SET. I missed it.

And this change was worth to be documented.

@vstinner

vstinner commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

And this change was worth to be documented.

My experience with rebuilding Fedora with a newer Python version is that every single minor change breaks at least one Python package, and it's a pain to find which change broke the package, and then find information about the change. IMO it's a good practice to document changes which are backward incompatible on purpose, even if the new behavior was the documented behavior.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@vstinner @adorilson
bpo-30459: Cast the result of PyCell_SET to void (pythonGH-23654)
278699c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot