◐ Shell
reader mode source ↗
Skip to content

bpo-40600: atexit only loads single time per interpreter#23699

Closed
corona10 wants to merge 5 commits into
python:masterfrom
corona10:bpo-40600-iss
Closed

bpo-40600: atexit only loads single time per interpreter#23699
corona10 wants to merge 5 commits into
python:masterfrom
corona10:bpo-40600-iss

Conversation

@corona10

@corona10 corona10 commented Dec 8, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@corona10 corona10 requested review from encukou and vstinner December 8, 2020 16:51
vstinner
vstinner requested changes Dec 8, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I would prefer to move the atexit list of callbacks into PyInterpreterState, and the atexit module would get the list from the current interpreter.

@bedevere-bot

bedevere-bot commented Dec 8, 2020

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be put in the comfy chair!

@corona10

corona10 commented Dec 8, 2020

Copy link
Copy Markdown
Member Author

@vstinner Ah okay, I will update the PR by tomorrow ;)

@corona10 corona10 force-pushed the bpo-40600-iss branch 2 times, most recently from d9bee4e to 9c4d2b0 Compare December 10, 2020 17:02
@corona10

corona10 commented Dec 10, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Dec 10, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@corona10 corona10 changed the title bpo-40600: atexit only loads sinle time per interpreter Dec 10, 2020
@encukou

encukou commented Dec 15, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This is solved in a different way in bpo-42639.
Thank you for working on this issue, even though this PR didn't make it in!

@encukou encukou closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @bedevere-bot @encukou @vstinner @the-knights-who-say-ni