◐ Shell
reader mode source ↗
Skip to content

bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes#238

Merged
brettcannon merged 8 commits into
python:masterfrom
ilevkivskyi:document-bytecodes-1
Mar 3, 2017
Merged

bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes#238
brettcannon merged 8 commits into
python:masterfrom
ilevkivskyi:document-bytecodes-1

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Feb 22, 2017

Copy link
Copy Markdown
Member

This needs to be backported to 3.5 and 3.6

This fixes http://bugs.python.org/issue26213

@serhiy-storchaka Please take a look

@zhangyangyu zhangyangyu added docs Documentation in the Doc dir needs backport to 3.5 labels Feb 22, 2017
@ilevkivskyi ilevkivskyi mentioned this pull request Feb 22, 2017
Merged
@ilevkivskyi

ilevkivskyi commented Feb 22, 2017

Copy link
Copy Markdown
Member Author

Serhiy, thank you for review! I implemented your comments in a new commit.

@ilevkivskyi

ilevkivskyi commented Feb 22, 2017

Copy link
Copy Markdown
Member Author

Thanks! I have implemented new comments in another commit.

@ilevkivskyi

ilevkivskyi commented Feb 22, 2017

Copy link
Copy Markdown
Member Author

2 * count is an expression, all expressions are formatted with ``.

Fixed.

serhiy-storchaka
serhiy-storchaka approved these changes Feb 22, 2017
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Now it LGTM. Thank you Ivan. But would be nice if some native speaker take a look.

@ilevkivskyi

ilevkivskyi commented Feb 23, 2017

Copy link
Copy Markdown
Member Author

Now it LGTM. Thank you Ivan. But would be nice if some native speaker take a look.

@briancurtin Could you please also take a look at this?

Note that I will update the BUILD_MAP_UNPACK_WITH_CALL docs in a separate PR (or maybe I will just update #239) after this is merged.

@ilevkivskyi

ilevkivskyi commented Feb 23, 2017

Copy link
Copy Markdown
Member Author

Now it LGTM. Thank you Ivan. But would be nice if some native speaker take a look.

@brettcannon Could you please also take a look at this?

Note that I will update the BUILD_MAP_UNPACK_WITH_CALL docs in a separate PR (or maybe I will just update #239) after this is merged.

@briancurtin Sorry for disturbing! This was intended for @brettcannon

@ilevkivskyi

ilevkivskyi commented Feb 24, 2017

Copy link
Copy Markdown
Member Author

Implements iterable unpacking for displays <type_display>
Other than that change, which I believe would be beneficial, the rest look good to me

Thanks! Fixed this in a new commit.

@brettcannon

brettcannon commented Mar 3, 2017

Copy link
Copy Markdown
Member

I tweaked a single word in the PR. Once Travis is green again I'll merge and backport.

@brettcannon brettcannon changed the title bpo-26213: Document _UNPACK bytecodes added in 3.5 and BUILD_MAP changes Mar 3, 2017
@brettcannon brettcannon merged commit 0705f66 into python:master Mar 3, 2017
brettcannon pushed a commit to brettcannon/cpython that referenced this pull request Mar 3, 2017
@ilevkivskyi @brettcannon
bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (python#238) …
c91a725 
(cherry picked from commit 0705f66)
brettcannon pushed a commit to brettcannon/cpython that referenced this pull request Mar 3, 2017
@ilevkivskyi @brettcannon
bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (python#238) …
9fe1329 
(cherry picked from commit 0705f66)
@serhiy-storchaka

serhiy-storchaka commented Mar 4, 2017

Copy link
Copy Markdown
Member

Thank you Ivan and Brett.

jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Move coverage into dev-requirements.txt (#238)
9a30fdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

+1 more reviewer

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ilevkivskyi @brettcannon @serhiy-storchaka @DimitrisJim @zhangyangyu @Mariatta @the-knights-who-say-ni