◐ Shell
reader mode source ↗
Skip to content

bpo-42745: Make the type cache per-interpreter#23947

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:method_cache
Dec 26, 2020
Merged

bpo-42745: Make the type cache per-interpreter#23947
vstinner merged 1 commit into
python:masterfrom
vstinner:method_cache

Conversation

@vstinner

@vstinner vstinner commented Dec 25, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Make the type attribute lookup cache per-interpreter.

Remove MCACHE macro: the cache is no longer disabled if the
EXPERIMENTAL_ISOLATED_SUBINTERPRETERS macro is defined.

https://bugs.python.org/issue42745

@vstinner

vstinner commented Dec 25, 2020

Copy link
Copy Markdown
Member Author

MCACHE_ prefix stands for "method cache", I chose to leave it unchanged.

@vstinner

vstinner commented Dec 26, 2020

Copy link
Copy Markdown
Member Author

My PR is wrong:

 7 tests failed:
     test__xxsubinterpreters test_ast test_atexit test_capi test_embed
     test_interpreters test_threading

@vstinner

vstinner commented Dec 26, 2020

Copy link
Copy Markdown
Member Author

This PR can be tested using PR #20085.

@vstinner
bpo-42745: Make the type cache per-interpreter …
bf67d11 
Make the type attribute lookup cache per-interpreter.

Add _PyType_InitCache() function, called by PyInterpreterState_New().

Remove MCACHE macro: the cache is no longer disabled if the
EXPERIMENTAL_ISOLATED_SUBINTERPRETERS macro is defined.

Continue to share next_version_tag between interpreters, since static
types are still shared by interpreters.
@vstinner

vstinner commented Dec 26, 2020

Copy link
Copy Markdown
Member Author

My PR is wrong: (...)

It should now be fixed: I added _PyType_InitCache() and I left next_version_tag unchanged.

@vstinner vstinner merged commit 4101018 into python:master Dec 26, 2020
@vstinner vstinner deleted the method_cache branch December 26, 2020 00:45
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@vstinner @adorilson
bpo-42745: Make the type cache per-interpreter (pythonGH-23947) …
e0b912e 
Make the type attribute lookup cache per-interpreter.

Add private _PyType_InitCache() function, called by PyInterpreterState_New().

Continue to share next_version_tag between interpreters, since static
types are still shared by interpreters.

Remove MCACHE macro: the cache is no longer disabled if the
EXPERIMENTAL_ISOLATED_SUBINTERPRETERS macro is defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot