Current _sqlite3 AC conversion status:

• Module level functions, except connect() (bpo-40956: Convert _sqlite3 module level functions to Argument Clinic #22484)
• Connection, except __init__ (bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 #23341 and bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 2 #23838)
• Row (bpo-40956: Convert _sqlite3.Row to Argument Clinic #23964)
• Cursor (this PR)
• Cache
• _sqlite3.connect() and _sqlite3.Connection.__init__

@corona10 / @serhiy-storchaka, would one of you like to review this? I've gone through the argument specs twice, but please take an extra look in case I've missed something.

FYI, Ubuntu tests fail at test_ttk_guionly, not at test_sqlite.

The macOS check at https://github.com/python/cpython/runs/1625929931 triggered by e9535b8 should've failed: the sqlite3 module was not built! (The fix, commit 64b9c36, was pushed right after e9535b8)

I guess this should be reported as a CI bug, @serhiy-storchaka?

EDIT
Not a CI bug, but a "build bug"?

bash$ git checkout e9535b83a13acb1b7b9b63ba43cbb57834d2e9cb
bash$ make
[…]
Modules/_sqlite/cursor.c:645:50: error: use of undeclared identifier 'parameters'
    return _pysqlite_query_execute(self, 1, sql, parameters);
                                                 ^
1 error generated.

Python build finished successfully!
[…]
Failed to build these modules:
_sqlite3                                                       
[…]
bash$ echo $?
0

PTAL, @serhiy-storchaka. Any idea why test_ttk_guionly on Ubuntu keeps failing? I can't see that that test uses sqlite3 in any way...

EDIT force-pushed to trigger CI

Thanks for reviewing, @serhiy-storchaka !

test_ttk_guionly is something unstable test. Sometimes (rarely) it fails on buildbots.

But currently test_nntplib is failed because of network issues.

FYI, I'm ready with the PR for _sqlite3.Cache when this gets merged, @serhiy-storchaka. It's a pretty small PR. The diff stat is 3 files changed, 43 insertions(+), 18 deletions(-) excluding autogenerated clinic code.

Please merge with master to fix test failures.

Please merge with master to fix test failures.

Done. Is there anything more you need from me before merging?

Thanks, @berkerpeksag