◐ Shell
reader mode source ↗
Skip to content

bpo-40956: Convert _sqlite3.Cache to Argument Clinic#24135

Closed
erlend-aasland wants to merge 1 commit into
python:masterfrom
erlend-aasland:bpo-40956/part5-cache
Closed

bpo-40956: Convert _sqlite3.Cache to Argument Clinic#24135
erlend-aasland wants to merge 1 commit into
python:masterfrom
erlend-aasland:bpo-40956/part5-cache

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jan 6, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

skip news

@erlend-aasland

erlend-aasland commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

FYI, rebased onto master bco. #20828

@erlend-aasland erlend-aasland mentioned this pull request Jan 7, 2021
Closed
@erlend-aasland

erlend-aasland commented Jan 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@berkerpeksag What about ditching the whole Cache/Node stuff and just use functools.lru_cache? Pro: It would get rid of a lot of code. Con: It might be a little bit slower. Worth pursuing as a future enhancement?

@erlend-aasland

erlend-aasland commented Jan 10, 2021

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka Would you mind reviewing this?

@berkerpeksag

berkerpeksag commented Jan 11, 2021

Copy link
Copy Markdown
Member

@berkerpeksag What about ditching the whole Cache/Node stuff and just use functools.lru_cache?

I'm usually not a fan of changing code that has been working fine for more than a decade, but let me think about it a bit.

I'm going to review this PR this week.

@erlend-aasland

erlend-aasland commented Jan 11, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor Author

I'm usually not a fan of changing code that has been working fine for more than a decade, but let me think about it a bit.

That's a valid argument, but take a look at my arguments at bpo-42862.

I'm going to review this PR this week.

Great, thanks.

@erlend-aasland

erlend-aasland commented Jan 12, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, @serhiy-storchaka 🙏🏻

@erlend-aasland

erlend-aasland commented Jan 12, 2021

Copy link
Copy Markdown
Contributor Author

Closing this, as it has been made obsolete by #24203.

@erlend-aasland erlend-aasland deleted the bpo-40956/part5-cache branch February 2, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@berkerpeksag berkerpeksag

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @berkerpeksag @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot