{{ message }}
bpo-30782: Allow limiting the number of concurrent tasks in asyncio.as_completed#2424
Closed
andybalaam wants to merge 3 commits into
Closed
bpo-30782: Allow limiting the number of concurrent tasks in asyncio.as_completed#2424andybalaam wants to merge 3 commits into
andybalaam wants to merge 3 commits into
Conversation
Sorry, something went wrong.
|
@andybalaam, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1st1, @bitdancer and @methane to be potential reviewers. |
Sorry, something went wrong.
andybalaam
changed the title
auvipy
suggested changes
Jun 2, 2019
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
re base please
Sorry, something went wrong.
Contributor
|
@andybalaam, thank you for your contribution to CPython. @1st1 and @asvetlov had marked this on the bug tracker as "won't fix", so I'm going to close this with that in mind. If the status changes, then this can be reopened. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer
8 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
See http://bugs.python.org/issue30782 - I propose adding a "limit" argument to asyncio.as_completed.
Justification is in the linked bug and my blog posts: http://www.artificialworlds.net/blog/2017/06/12/making-100-million-requests-with-python-aiohttp/
The "Allow passing a coroutine to as_completed" part may be the most controversial because it turns off checking for some types of error, but I think it is necessary to achieve what I am trying to do.