◐ Shell
reader mode source ↗
Skip to content

bpo-40956: [regression] first argument in sqlite3.Connection.backup is mandatory#24503

Merged
berkerpeksag merged 4 commits into
python:masterfrom
erlend-aasland:sqlite-fix-backup
Feb 10, 2021
Merged

bpo-40956: [regression] first argument in sqlite3.Connection.backup is mandatory#24503
berkerpeksag merged 4 commits into
python:masterfrom
erlend-aasland:sqlite-fix-backup

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 10, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Regression introduced by GH-23838.

https://bugs.python.org/issue40956

@erlend-aasland

erlend-aasland commented Feb 10, 2021

Copy link
Copy Markdown
Contributor Author

@berkerpeksag would you please review?

@erlend-aasland

erlend-aasland commented Feb 10, 2021

Copy link
Copy Markdown
Contributor Author

skip news

berkerpeksag
berkerpeksag requested changes Feb 10, 2021
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Could you please add a test case to confirm that the regression is fixed by this?

You can rename test_bad_target_none to test_bad_target and add the new test here:

cpython/Lib/sqlite3/test/backup.py

Lines 20 to 22 in 749d40a

def test_bad_target_none(self):
with self.assertRaises(TypeError):
self.cx.backup(None)

@bedevere-bot

bedevere-bot commented Feb 10, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@berkerpeksag

berkerpeksag commented Feb 10, 2021

Copy link
Copy Markdown
Member

And this is actually need a NEWS entry because the previous PR has already been released in 3.10 alphas.

@erlend-aasland

erlend-aasland commented Feb 10, 2021

Copy link
Copy Markdown
Contributor Author

Could you please add a test case to confirm that the regression is fixed by this?

Sure, I'll do it first thing tomorrow.

And this is actually need a NEWS entry because the previous PR has already been released in 3.10 alphas.

I see. Thanks for the heads-up.

@erlend-aasland

erlend-aasland commented Feb 10, 2021

Copy link
Copy Markdown
Contributor Author

BTW, will you have time to review #24203 and #24421 any time soon?

@berkerpeksag

berkerpeksag commented Feb 10, 2021

Copy link
Copy Markdown
Member

BTW, will you have time to review #24203 and #24421 any time soon?

I'm on holidays at the moment so will see :) They are definitely on my TODO list, though.

@erlend-aasland

erlend-aasland commented Feb 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

BTW, will you have time to review #24203 and #24421 any time soon?

I'm on holidays at the moment so will see :) They are definitely on my TODO list, though.

Oops, sorry! Enjoy your days off :) Thanks!

(I have made the requested changes; please review again)

BTW, not sure about the NEWS entry. It felt a bit clumsy. Let me know if you want me to rephrase it.

@bedevere-bot

bedevere-bot commented Feb 10, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag
berkerpeksag approved these changes Feb 10, 2021
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM!

@erlend-aasland

erlend-aasland commented Feb 10, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, @berkerpeksag 🙏🏻

@berkerpeksag berkerpeksag merged commit ea46579 into python:master Feb 10, 2021
@sthagen sthagen mentioned this pull request Feb 11, 2021
Merged
@erlend-aasland erlend-aasland deleted the sqlite-fix-backup branch February 11, 2021 08:02
@berkerpeksag berkerpeksag mentioned this pull request Feb 21, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-40956: Fix segfault when Connection.backup is called without targ… …
1bb6281 
…et (pythonGH-24503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @bedevere-bot @berkerpeksag @the-knights-who-say-ni