◐ Shell
reader mode source ↗
Skip to content

bpo-42128: Add what's new section for PEP 634 (pattern matching)#24588

Closed
gvanrossum wants to merge 1 commit into
python:masterfrom
gvanrossum:whatsnew-pattern-matching
Closed

bpo-42128: Add what's new section for PEP 634 (pattern matching)#24588
gvanrossum wants to merge 1 commit into
python:masterfrom
gvanrossum:whatsnew-pattern-matching

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Feb 19, 2021

Copy link
Copy Markdown
Member

Obviously this shouldn't be merged before the main pattern matching PR (GH-22917).

https://bugs.python.org/issue42128

@willingc willingc self-requested a review February 20, 2021 04:47
@willingc willingc self-assigned this Feb 20, 2021
@Fidget-Spinner

Fidget-Spinner commented Feb 21, 2021

Copy link
Copy Markdown
Member

Guido, thanks for updating what's new. What do you think of adding a small FAQ section in the what's new too? Or just mentioning that the new statements use soft keywords and old identifiers won't break?

I've seen quite a bit of FUD online, and I admit initially thinking my own code using match and case would break before I read the PEP thoroughly. So I think that placing a sentence in bold would help allay unfounded fears.

Maybe:

The match statement uses soft keywords.  Only lines beginning with ``match``, containing a subject, a colon, and a line break will be identified as a match statement.  Existing code using ``match`` as identifiers for variable names or functions will not break.

Alternatively, copied straight from the PEP:

The match and case keywords are *soft keywords*, i.e. they
are not reserved words in other grammatical contexts (including at the start of
a line if there is no colon where expected). This implies that they are
recognized as keywords when part of a match statement or case block only, and
are allowed to be used in all other contexts as variable or argument names.

BTW, Daniel and I are tracking some of our own docs works here https://github.com/dmoisset/cpython/issues , though admittedly I haven't done much yet and I plan to sprint it over this weekend ;).

@gvanrossum

Copy link
Copy Markdown
Member Author

What do you think of adding a small FAQ section in the what's new too? Or just mentioning that the new statements use soft keywords and old identifiers won't break?

Thanks for the reminder -- this indeed an important point. I believe this PR is likely dead, and it looks like @willingc is going to write us a better section.

@willingc

Copy link
Copy Markdown
Contributor

@gvanrossum I'm half way through the What's New and should post it tomorrow.

@gvanrossum

Copy link
Copy Markdown
Member Author

Thanks @willingc just in time for 3.10a6!

@willingc

willingc commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

@gvanrossum Any objections to closing this PR?

@gvanrossum

Copy link
Copy Markdown
Member Author

Sorry, forgot!

@gvanrossum gvanrossum closed this Mar 1, 2021
@gvanrossum gvanrossum deleted the whatsnew-pattern-matching branch August 7, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants