◐ Shell
reader mode source ↗
Skip to content

bpo-37146: Deactivate opcode cache only when using huntrleaks in the test suite#24643

Merged
pablogsal merged 5 commits into
python:masterfrom
pablogsal:bpo-37136
Feb 28, 2021
Merged

bpo-37146: Deactivate opcode cache only when using huntrleaks in the test suite#24643
pablogsal merged 5 commits into
python:masterfrom
pablogsal:bpo-37136

Conversation

@pablogsal

@pablogsal pablogsal commented Feb 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue37146

This allows us to run the opcode cache in debug mode, as catching bugs related to the opcode cache was quite hard due to it not being activated by default in this case.

@pablogsal pablogsal requested a review from vstinner February 24, 2021 22:41
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2021
@bedevere-bot

bedevere-bot commented Feb 24, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 0372254fc3556cc2d3a7fb07f39f38b0b86ccb29 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2021
@gvanrossum

gvanrossum commented Feb 25, 2021

Copy link
Copy Markdown
Member

Thanks!

@brandtbucher brandtbucher mentioned this pull request Feb 25, 2021
Merged
pablogsal and others added 3 commits February 27, 2021 19:33
@pablogsal
bpo-37146: Deactivate opcode cache only when using huntrleaks in the … …
0c0f5d8 
…test suite
@pablogsal @vstinner
Update Include/cpython/ceval.h …
c11e70f 
Co-authored-by: Victor Stinner <vstinner@python.org>
@pablogsal @vstinner
Update Python/ceval.c …
a9680bc 
Co-authored-by: Victor Stinner <vstinner@python.org>
gvanrossum
gvanrossum approved these changes Feb 27, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

One comment nit. This addresses my concern nicely.

pablogsal and others added 2 commits February 27, 2021 23:16
@pablogsal @gvanrossum
Update Python/ceval.c …
2356931 
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
@pablogsal
Add comment about bpo-3714
68b0f83
@pablogsal pablogsal merged commit af5fa13 into python:master Feb 28, 2021
@pablogsal pablogsal deleted the bpo-37136 branch February 28, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@methane methane methane left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @bedevere-bot @gvanrossum @vstinner @methane @the-knights-who-say-ni