◐ Shell
reader mode source ↗
Skip to content

Docs: improve accuracy of socketserver reference#24767

Merged
erlend-aasland merged 9 commits into
python:mainfrom
geryogam:patch-16
Nov 29, 2022
Merged

Docs: improve accuracy of socketserver reference#24767
erlend-aasland merged 9 commits into
python:mainfrom
geryogam:patch-16

Conversation

@geryogam

@geryogam geryogam commented Mar 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

In the documentation of the socketserver standard library:

  • update a restricted statement; the address family difference between TCPServer and UnixStreamServer is also true between UDPServer and UnixDatagramServer, as the second clause of the sentence and the implementation show;

  • update an obsolete statement; since Python 3.6 the StreamRequestHandler.wfile attribute also supports the io.BufferedIOBase writable interface:

    Changed in version 3.6: StreamRequestHandler.wfile also supports the io.BufferedIOBase writable interface.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 5, 2021
@github-actions

github-actions Bot commented Apr 8, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 8, 2021
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 5, 2022
erlend-aasland
erlend-aasland reviewed Nov 27, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Based on Éric's review and my own observations, I suggest closing this PR.

@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Nov 27, 2022
@erlend-aasland

erlend-aasland commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Please update the PR title to reflect the actual change.

@geryogam geryogam changed the title Update socketserver.rst Nov 28, 2022
@geryogam

geryogam commented Nov 28, 2022

Copy link
Copy Markdown
Contributor Author

Please update the PR title to reflect the actual change.

Updated.

@geryogam @merwok
Update Doc/library/socketserver.rst …
a55c279 
Co-authored-by: Éric <merwok@netwok.org>
@erlend-aasland erlend-aasland changed the title Update obsolete or restricted statements in the socketserver documentation Nov 29, 2022
erlend-aasland
erlend-aasland approved these changes Nov 29, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

lgtm; thanks

17 hidden items Load more…
@erlend-aasland erlend-aasland added skip issue needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed pending The issue will be closed if no feedback is provided labels Nov 29, 2022
@erlend-aasland erlend-aasland self-assigned this Nov 29, 2022
@erlend-aasland erlend-aasland merged commit 052bc12 into python:main Nov 29, 2022
@miss-islington

miss-islington commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @maggyero for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 29, 2022

Copy link
Copy Markdown

GH-99884 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2022
@geryogam @miss-islington
Docs: improve accuracy of socketserver reference (pythonGH-24767) …
1f96fe5 
(cherry picked from commit 052bc12)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@bedevere-bot bedevere-bot removed the only security fixes label Nov 29, 2022
@bedevere-bot

bedevere-bot commented Nov 29, 2022

Copy link
Copy Markdown

GH-99885 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2022
@geryogam @miss-islington
Docs: improve accuracy of socketserver reference (pythonGH-24767) …
ca87913 
(cherry picked from commit 052bc12)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 29, 2022
miss-islington added a commit that referenced this pull request Nov 29, 2022
@miss-islington @geryogam
Docs: improve accuracy of socketserver reference (GH-24767) …
3baaa97 
(cherry picked from commit 052bc12)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
miss-islington added a commit that referenced this pull request Nov 29, 2022
@miss-islington @geryogam
Docs: improve accuracy of socketserver reference (GH-24767) …
d7c2e0a 
(cherry picked from commit 052bc12)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@geryogam

geryogam commented Nov 29, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review!

@geryogam geryogam deleted the patch-16 branch November 29, 2022 21:26
carljm added a commit to carljm/cpython that referenced this pull request Dec 1, 2022
@carljm
Merge branch 'main' into fixinspect …
12f7659 
* main: (112 commits)
  pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895)
  pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613)
  Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917)
  pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916)
  pythongh-89189: More compact range iterator (pythonGH-27986)
  bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491)
  pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906)
  pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850)
  pythongh-99845: Use size_t type in __sizeof__() methods (python#99846)
  pythonGH-99877)
  Fix typo in exception message in `multiprocessing.pool` (python#99900)
  pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869)
  pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893)
  pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825)
  pythonGH-81057: remove static state from suggestions.c (python#99411)
  Improve zip64 limit error message (python#95892)
  pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591)
  pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128)
  pythongh-82836: fix private network check (python#97733)
  Docs: improve accuracy of socketserver reference (python#24767)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

@erlend-aasland erlend-aasland

Labels

Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@geryogam @erlend-aasland @miss-islington @bedevere-bot @merwok @the-knights-who-say-ni @ezio-melotti @AlexWaygood